On 11 May 2016 at 21:19, Aaryaman Vasishta jem456.vasishta@gmail.com wrote:
+void d3drm_texture_destroy(struct d3drm_texture *texture)
This should be static. I.e.: +static void d3drm_texture_destroy(struct d3drm_texture *texture)
Adding static prevents the function from being available outside of texture.c. (See also http://port70.net/~nsz/c/c89/c89-draft.html#3.1.2.2 for the details, although "The C Programming Language" by Kernighan & Ritchie makes for better reading.) Applies to d3drm_validate_image() as well.