Re: crypt32: Fix a failing test in win9x

[Paul Vriens]

James Hawkins wrote:
> Hi,
>
> Changelog:
> - Fix a failing test in win9x.
>
> dlls/crypt32/tests/ctl.c |   15 +++++++++++----
>  1 files changed, 11 insertions(+), 4 deletions(-)

The !ret in:

+    else
+    {
+        ok(!ret && GetLastError() == CRYPT_E_EXISTS,
+           "expected CRYPT_E_EXISTS, got %d %08x\n", ret, GetLastError());
+    }

is superfluous.

crypt32: Fix a failing test in win9x

[James Hawkins]

On Thu, Sep 11, 2008 at 1:42 AM, Paul Vriens  wrote:
> >
>
> The !ret in:
> - else
> - {
> -
>    ok(!ret && GetLastError() == CRYPT_E_EXISTS,
> -
>       "expected CRYPT_E_EXISTS, got %d %08x\n", ret, GetLastError());
> - }
>
> is superfluous.

It is, but I'm sticking with precedent in leaving the original test in
place.  Please remove wine-patches from the CC when you reply to a
patch.

crypt32: Fix a failing test in win9x

[Paul Vriens]

James Hawkins wrote:
> On Thu, Sep 11, 2008 at 1:42 AM, Paul Vriens  wrote:
> > The !ret in:
> > - else
> > - {
> > -
> >    ok(!ret && GetLastError() == CRYPT_E_EXISTS,
> > -
> >       "expected CRYPT_E_EXISTS, got %d %08x\n", ret, GetLastError());
> > - }
> >
> > is superfluous.
>
> It is, but I'm sticking with precedent in leaving the original test in
> place.  Please remove wine-patches from the CC when you reply to a
> patch.

Yeah, I think this is the first time I didn't pay attention to that, sorry.