[PATCH] httpapi: Fix a memory leak (Valgrind).

[Sven Baars]

Signed-off-by: Sven Baars 
---
 dlls/httpapi/httpapi_main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/dlls/httpapi/httpapi_main.c b/dlls/httpapi/httpapi_main.c
index 0d6895b998..03511d6c9f 100644
--- a/dlls/httpapi/httpapi_main.c
+++ b/dlls/httpapi/httpapi_main.c
@@ -230,6 +230,7 @@ static ULONG add_url(HANDLE queue, const WCHAR *urlW, HTTP_URL_CONTEXT context)
             offsetof(struct http_add_url_params, url[len]), NULL, 0, NULL, &ovl))
         ret = GetLastError();
     CloseHandle(ovl.hEvent);
+    heap_free(params);
     return ret;
 }

[PATCH] httpapi/tests: Initialize response_buffer to 0 (Valgrind).

[Sven Baars]

Signed-off-by: Sven Baars 
---
 dlls/httpapi/tests/httpapi.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/dlls/httpapi/tests/httpapi.c b/dlls/httpapi/tests/httpapi.c
index 5da7101417..b19a590147 100644
--- a/dlls/httpapi/tests/httpapi.c
+++ b/dlls/httpapi/tests/httpapi.c
@@ -614,6 +614,8 @@ static void test_v1_entity_body(void)
     ret = HttpSendHttpResponse(queue, req->RequestId, 0, (HTTP_RESPONSE *)&response, NULL, NULL, NULL, 0, NULL, NULL);
     ok(!ret, "Got error %u.\n", ret);

+    memset(response_buffer, 0, sizeof(response_buffer));
+
     ret = recv(s, response_buffer, sizeof(response_buffer), 0);
     ok(ret > 0, "recv() failed.\n");
     if (winetest_debug > 1)

[PATCH] httpapi/tests: Cancel a pending recieve request (Valgrind).

[Sven Baars]

Signed-off-by: Sven Baars 
---
 dlls/httpapi/tests/httpapi.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/dlls/httpapi/tests/httpapi.c b/dlls/httpapi/tests/httpapi.c
index b19a590147..abc5c95f0c 100644
--- a/dlls/httpapi/tests/httpapi.c
+++ b/dlls/httpapi/tests/httpapi.c
@@ -534,6 +534,8 @@ static void test_v1_short_buffer(void)
     ok(!ret, "Got error %u.\n", ret);
     ok(req->RequestId == req_id, "Got request ID %s.\n", wine_dbgstr_longlong(req->RequestId));

+    CancelIoEx(queue, &ovl);
+
     ret = HttpRemoveUrl(queue, localhost_urlW);
     ok(!ret, "Got error %u.\n", ret);
     closesocket(s);

[PATCH] httpapi/tests: Cancel a pending recieve request (Valgrind).

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=56976

Your paranoid android.

=== wxppro (32 bit report) ===

httpapi:
httpapi: Timeout

=== w2003std (32 bit report) ===

httpapi:
httpapi: Timeout