Re: [PATCH 4/7] msvcp90: Added char_traits<unsigned short> implementation (try2)

[Alexandre Julliard]

Piotr Caban  writes:
> +/* ?not_eof@?$char_traits@G@std@@SAGABG@Z */
> +unsigned short CDECL MSVCP_char_traits_short_not_eof(const unsigned short *in)
> +{
> - return (*in==0 ? !0 : *in);
>
> +}

Aren't you supposed to return 0 for eof?

[PATCH 4/7] msvcp90: Added char_traits<unsigned short> implementation (try2)

[Piotr Caban]

On 07/21/10 10:14, Alexandre Julliard wrote:
> Piotr Caban  writes:
> > +/* ?not_eof@?$char_traits@G@std@@SAGABG@Z */
> > +unsigned short CDECL MSVCP_char_traits_short_not_eof(const unsigned short *in)
> > +{
> > - return (*in==0 ? !0 : *in);
> >
> > +}
>
> Aren't you supposed to return 0 for eof?

eof should be equal to -1, this function should return 0 if *in==-1. 
I've sent fixed version of this patch.