Re: [PATCH v2 10/11] progman: Use proper size for combobox controls

[Alexandre Julliard]

Fabian Maurer  writes:
> Signed-off-by: Fabian Maurer
>
> programs/progman/progman.rc | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/programs/progman/progman.rc b/programs/progman/progman.rc
> index 4804330aed..9f451a736b 100644
> --- a/programs/progman/progman.rc
> +++ b/programs/progman/progman.rc
> @@ -119,7 +119,7 @@ LTEXT         "",                     PM_PROGRAM,         95,  5,  90, 15
>  LTEXT         "From group:", -1,            5, 13,  90, 15
>  LTEXT         "",                     PM_FROM_GROUP,      95, 13,  90, 15
>  LTEXT         "&To group:",   PM_TO_GROUP_TXT,     5, 28, 140, 15
> -COMBOBOX                              PM_TO_GROUP,         5, 38, 140, 50, WS_TABSTOP | CBS_DROPDOWNLIST
> +COMBOBOX                              PM_TO_GROUP,         5, 38, 140, 60, WS_TABSTOP | CBS_DROPDOWNLIST

That kind of change doesn't seem necessary. We don't need all comboboxes
to have the exact same height, only something reasonable.

[PATCH v2 10/11] progman: Use proper size for combobox controls

[Fabian Maurer]

> > -COMBOBOX                              PM_TO_GROUP,         5, 38, 140,
> > 50, WS_TABSTOP | CBS_DROPDOWNLIST +COMBOBOX                             
> > PM_TO_GROUP,         5, 38, 140, 60, WS_TABSTOP | CBS_DROPDOWNLIST
>
> That kind of change doesn't seem necessary. We don't need all comboboxes
> to have the exact same height, only something reasonable.

Well, my intention was to keep the size the same as it was before my patch. 
Wine used to make comboboxes at least 5 items in height, that was the broken 
behavior, and since I didn't want to cause a change in look I decided to set 
it to a height of 60, which equals 5 items in height again.

I'm fine with the height being different of course, just give me your ok and 
I'll provide an updated patchset. Need to know what the minimal size you deem 
ok is though, to me 5 items in the drop down list looks fine, but only 2 or 3 
is a bit small in my opinion...

Regards,
Fabian Maurer

Wine packaged as appImage?

[Mikhail V.]

Hello,

following Bob Wya's suggestion in this forum post:
https://forum.winehq.org/viewtopic.php?f=8&t=28708
I would like to ask:

are there any plans to package Wine as appImage?

if this question was already asked (and answered) in this mailing list then it would be nice to make such answer public (fin aforementioned forum topic maybe?) so that people like me would not pollute this mailing list by asking it again :)

Thanks,
Mikhail