Re: [shell32/tests] Initialize an APPBARDATA struct (Valgrind)

[Alexandre Julliard]

Paul Vriens  writes:
> Fixes some Valgrind warnings.
>
> Changelog
>   Initialize an APPBARDATA struct (Valgrind)

That's just hiding the problem, an app can pass the same structure.

[shell32/tests] Initialize an APPBARDATA struct (Valgrind)

[Paul Vriens]

On 12/17/2009 05:27 PM, Alexandre Julliard wrote:
> Paul Vriens  writes:
> > Fixes some Valgrind warnings.
> >
> > Changelog
> >    Initialize an APPBARDATA struct (Valgrind)
>
> That's just hiding the problem, an app can pass the same structure.

So the 'users' should be fixed?

[shell32/tests] Initialize an APPBARDATA struct (Valgrind)

[Alexandre Julliard]

Paul Vriens  writes:
> > That's just hiding the problem, an app can pass the same structure.
>
> So the 'users' should be fixed?

We need to define a platform-independent struct for marshalling that
data across processes anyway, we can't blindly send the structure.

[shell32/tests] Initialize an APPBARDATA struct (Valgrind)

[Paul Vriens]

On 12/17/2009 06:26 PM, Alexandre Julliard wrote:
> Paul Vriens  writes:
> > > That's just hiding the problem, an app can pass the same structure.
> >
> > So the 'users' should be fixed?
>
> We need to define a platform-independent struct for marshalling that
> data across processes anyway, we can't blindly send the structure.

And I thought I picked an easy one, that'll teach me ;)