Re: Correctly unicodify winmm/mmio.c

[Eric Pouech]

Vincent Béron wrote:
> Changelog:
> Correctly unicodify winmm/mmio.c.

don't apply this patch, it's plain wrong.
the A<->W message mapping isn't implemented yet, and all our internal 
handlers are still ANSI.
The steps to go are (in order):
- implement A<->W message mapping for MMIO
- translate our internal handlers to unicode
- then apply this patch
A+

Correctly unicodify winmm/mmio.c

[Andreas Mohr]

Hi,

On Tue, Oct 18, 2005 at 08:21:55AM +0200, Eric Pouech wrote:
> Vincent Béron wrote:
> > Changelog:
> > Correctly unicodify winmm/mmio.c.
>
> don't apply this patch, it's plain wrong.
> the A<->W message mapping isn't implemented yet, and all our internal 
> handlers are still ANSI.

I was just thinking of sending a mail why all those unicode conversions
(which could easily compromise stability a LOT) were being done exactly at this moment
when we're busy trying to get Wine as stable as possible for a 0.9...

If there's any sort of patch that shouldn't get applied despite enhancing Wine to
a certain point, then I'd think those are it...

Andreas Mohr

Correctly unicodify winmm/mmio.c

[Vincent Béron]

Le mar 18/10/2005 à 02:55, Andreas Mohr a écrit :
> Hi,
>
> On Tue, Oct 18, 2005 at 08:21:55AM +0200, Eric Pouech wrote:
> > Vincent Béron wrote:
> > > Changelog:
> > > Correctly unicodify winmm/mmio.c.
> >
> > don't apply this patch, it's plain wrong.
> > the A<->W message mapping isn't implemented yet, and all our internal 
> > handlers are still ANSI.

Thank you Éric for pointing this out, I didn't know it.
> I was just thinking of sending a mail why all those unicode conversions
> (which could easily compromise stability a LOT) were being done exactly at this moment
> when we're busy trying to get Wine as stable as possible for a 0.9...
>
> If there's any sort of patch that shouldn't get applied despite enhancing Wine to
> a certain point, then I'd think those are it...

Ok, I won't send any more of them for now.

Vincent