Re: To error out or to skip tests?

[Greg Geldorp]

Hi Jörg
> > The picture on test.winehq.org is a disaster: None of the w95, w98, nt4,
> > 2k, 2k3, Vista, 2k8, w7 machines have performed winmm:wave tests!
> > They all have no sound configured.  Mostly useless.
>
> A lot of those VMware boxes are mine. They come in two flavors. Some of
> them (starting with esx-) are ESX VMs, ESX is VMware's data center

product,
> which simply doesn't support sound. The others (starting with gvg-) are
> Server VMs, which do support sound. The reason I didn't configure sound
> on them is because I'm simply not interested in sound. I'll consider
> enabling sound, but to be honest I'm a bit put off by your aggressive

tone.
> Anyway, the end result is that there will always be ESX VMs that can't
> run sound tests.

After a bit of mucking around I got sound to work on the Linux host where
those VMware Server VMs run, and enabled sound in the VMs where possible. I
could not find correct sound drivers for some of the old stuff (NT4 and
below), so those still don't have sound, neither do the ESX VMs.

Best regards, Ge.

To error out or to skip tests?

[Paul Vriens]

On 11/17/2009 09:38 PM, Greg Geldorp wrote:
> Hi Jörg
> > > The picture on test.winehq.org is a disaster: None of the w95, w98, nt4,
> > > 2k, 2k3, Vista, 2k8, w7 machines have performed winmm:wave tests!
> > > They all have no sound configured.  Mostly useless.
> >
> > A lot of those VMware boxes are mine. They come in two flavors. Some of
> > them (starting with esx-) are ESX VMs, ESX is VMware's data center
>
> product,
> > which simply doesn't support sound. The others (starting with gvg-) are
> > Server VMs, which do support sound. The reason I didn't configure sound
> > on them is because I'm simply not interested in sound. I'll consider
> > enabling sound, but to be honest I'm a bit put off by your aggressive
>
> tone.
> > Anyway, the end result is that there will always be ESX VMs that can't
> > run sound tests.
>
> After a bit of mucking around I got sound to work on the Linux host where
> those VMware Server VMs run, and enabled sound in the VMs where possible. I
> could not find correct sound drivers for some of the old stuff (NT4 and
> below), so those still don't have sound, neither do the ESX VMs.

For W98 and WinME you should be able to use:

http://support.creative.com/downloads/download.aspx?nDownloadId=1843

I've installed these on both platforms without any problems.
> Best regards, Ge.

To error out or to skip tests?

Ge,
> After a bit of mucking around I got sound to work on the Linux host where
> those VMware Server VMs run, and enabled sound in the VMs where possible.

That's great.

I've not yet written the patch that'll silence machines without sound as I'm still thinking about how I'll implement "coherence tests", i.e.
 - a machine with no sound at all should skip everything without error;
 - yet a machine that passes play test #1 must also pass play test #2,
   i.e. the straight forward
    if (err==MCI_XY/*no sound*/) skip("no sound here, skipping\n");
   is not acceptable.  I'll do something more like
    ok(err==xyz && err==previous_similar_result,"...");
But it'll come...

Regards,
 Jörg Höhle.