Re: wine-devel Digest, Vol 20, Issue 30

[Alessandro Pignotti]

> Date: Thu, 8 Mar 2007 08:22:59 +0100
> From: Kai Blin
> > /* FIXME: Should we be storing these dwFlags or the creation ones? */
> > - lpPData = DP_CreatePlayer( This, lpidPlayer, lpPlayerName, dwFlags,
> > - /* I think we should pass creation flags, so we can distinguish
> >
> > sysplayers and not count them in the current +     player total */
> > - lpPData = DP_CreatePlayer( This, lpidPlayer, lpPlayerName,
> >
> > dwCreateFlags, hEvent, bAnsi );
>
> Every time someone uses "I think" in the code, usually this calls for a
> test case. This one should be rather straightforward to test.

It's not possible to write a conformance test because i'm using a flag 
internal to wine's implementation of directplay, It's possible to safely 
change "I think we should" with "we have to". I've used "i think" more as an 
answer to the previous FIXME comment we have inherited from the author of the 
code.

Regards
Alessandro Pignotti
> Cheers,
> Kai
>
> --
> Kai Blin, <kai Dot blin At gmail Dot com>
> WorldForge developer    http://www.worldforge.org/
> Wine developer          http://wiki.winehq.org/KaiBlin/
> --
> Will code for cotton.

wine-devel Digest, Vol 20, Issue 30

[Alexandre Julliard]

Alessandro Pignotti  writes:
> It's not possible to write a conformance test because i'm using a flag 
> internal to wine's implementation of directplay, It's possible to safely 
> change "I think we should" with "we have to". I've used "i think" more as an 
> answer to the previous FIXME comment we have inherited from the author of the 
> code.

If you have fixed the FIXME then you should remove it. The source code
isn't the right place to start a discussion with the previous author ;-)