Re: comctl32/tests: [try 2] Make the test dpi and Theme aware: use SM_CYSIZE

[Paul Vriens]

Detlef Riekenberg wrote:
> try 2: without the check for win9x
>
> The status test failed on installations with 120 dpi.
>
> After a lot of "try and error" from 72 to 144 dpi with
> different formula for the min height, different results on my machine
> and a failing XP machine at 96dpi, I found the reason:
>
> The minimal height depends on the appearance setting
> "[In]Active Title Bar", which is SM_CYSIZE.
>
> The test now pass on win98se, win2k and Wine with a different height
> for the title bar (tested from 18 to 30).
>
> To reduce the test log size, I moved the dump of the current tested
> font name from a trace to the ok.
>
> Why is MS so stupid and use BYTE in ENUMLOGFONTEXA and
> WCHAR in ENUMLOGFONTEXW for the strings in wingdi.h, 
> while MSDN document them as TCHAR?

Hi Detlef,

This patch introduced a lot of failures on specifically some XP and W2K3 boxes.

Could you have a look?

comctl32/tests: [try 2] Make the test dpi and Theme aware: use SM_CYSIZE

[Detlef Riekenberg]

On Mo, 2009-02-09 at 19:09 +0100, Paul Vriens wrote:
> This patch introduced a lot of failures on specifically some XP and W2K3 boxes.

grrr...
> Could you have a look?

Yes. I try to reproduce the failures.