Re: msvcrt[2/3]: add initial tests for dlls/msvcrt/data.c [try 2]

[Uwe Bonnes]

> > > > > "Andrew" == Andrew Ziem  writes:

Andrew> because tests yield inconsistent results */ +#if 0 + /* address

#if 0 
in a patch is depreciated. If the test fails on wine, butt succeeds in
windows, use todo_wine(). If there are other conditions that must be met,
tell these conditions, perhaps like

#define SOME_SPECIAL_TEST 0
#ifdef SOME_SPECIAL_TEST

so that others can decipher what you mean.

Bye

msvcrt[2/3]: add initial tests for dlls/msvcrt/data.c [try 2]

[Andrew Ziem]

Uwe Bonnes wrote:
> > > > > > "Andrew" == Andrew Ziem  writes:
> Andrew> because tests yield inconsistent results */ +#if 0 + /* address
>
> #if 0 
> in a patch is depreciated. If the test fails on wine, butt succeeds in
> windows, use todo_wine(). If there are other conditions that must be met,
> tell these conditions, perhaps like
>
> #define SOME_SPECIAL_TEST 0
> #ifdef SOME_SPECIAL_TEST
>
> so that others can decipher what you mean.

Sorry, I meant to document the conditions under which Windows 2000 
yields inconsistent results.  For example, in the first ok() on Windows 
2000, _initterm() returned either 0 or 1.

Also, one of the "#if 0" blocks documents a condition that crashes both 
Wine and Windows 2000.

Andrew

msvcrt[2/3]: add initial tests for dlls/msvcrt/data.c [try 2]

[Alexandre Julliard]

Andrew Ziem  writes:
> Sorry, I meant to document the conditions under which Windows 2000
> yields inconsistent results.  For example, in the first ok() on
> Windows 2000, _initterm() returned either 0 or 1.
>
> Also, one of the "#if 0" blocks documents a condition that crashes
> both Wine and Windows 2000.

As a rule, passing garbage to an API is not an interesting thing to
test, unless the API does something special with it on Windows.