Several things: - Don't set errno. For good practice it's more or less read-only. - All the tests have to pass after each patch, so if your tests fail (which they probably should) without your patch, add todo_wine and then remove them in the followup patch (or just send the tests second). - The tests you provided pass without this patch so I'm not convinced that your fix is necessary. errno 107 = ENOTCONN, so while 0 length sends work just fine, they only work when non-zero sends also work. i.e. invalid sends get turned to valid sends on windows when the length is 0. It might be better to test calling WSASendTo with 0 length on unconnected tcp (or udp if tcp doesn't work) sockets.
Good luck, Mike.
On Sat, Aug 14, 2010 at 5:45 AM, Wolfgang Schwotzer wolfgang.schwotzer@gmx.net wrote:
This solves #19397.
-
Mike Kaplinskiy