Re: oleaut32: Remove unused items

[Michael Stefaniuc]

Andrew Talbot wrote:
> Changelog:
>     oleaut32: Remove unused items.
>
> diff -urN a/dlls/oleaut32/vartype.c b/dlls/oleaut32/vartype.c
> --- a/dlls/oleaut32/vartype.c	2006-12-22 14:43:36.000000000 +0000
> +++ b/dlls/oleaut32/vartype.c	2007-01-13 20:13:23.000000000 +0000
> @@ -228,7 +228,6 @@
>  SIMPLE(LONG64, SHORT, VarI8FromI2);
>  SIMPLE(LONG64, signed char, VarI8FromI1);
>  SIMPLE(LONG64, USHORT, VarI8FromUI2);
> -SIMPLE(LONG64, LONG, VarI8FromI4);

Are you removing a test here?
> SIMPLE(LONG64, ULONG, VarI8FromUI4);
>  POSTST(LONG64, ULONG64, VarI8FromUI8, I8_MAX);

bye
    michael

oleaut32: Remove unused items

[Andrew Talbot]

Michael Stefaniuc wrote:
> > -SIMPLE(LONG64, LONG, VarI8FromI4);
>
> Are you removing a test here?

Hi Michael,

I'm not sure what you mean. All I know is that the "SIMPLE()" macro - also
in oleaut32/vartype.c - is defined as follows.

/* Inline return type */
#define RETTYP inline static HRESULT

/* Simple compiler cast from one type to another */
#define SIMPLE(dest, src, func) RETTYP _##func(src in, dest* out) { \
  *out = in; return S_OK; }

So
    SIMPLE(LONG64, LONG, VarI8FromI4);

generates a function definition similar to

inline static HRESULT _VarI8FromI4(LONG64 in, LONG* out)
{
    *out = in;
    return S_OK;
}

and _VarI8FromI4() is not called from anywhere within the codebase. In
particular, there is not a dll function similarly named but without the
leading underscore to call it. (Compare with VarI8FromI2(), which calls
_VarI8FromI2(), for example.)

VarI8FromI4() seems to be undocumented and unimplemented.

To complete the job - if my patch is otherwise correct - I should also
remove its declaration from include/oleaut.h.

Of course, it may be that this macro should be left in, perhaps marked
as "TODO". I welcome advice.

Thanks,

-- Andy.