Hello,
i've ported a test from the ReactOS-Project to wine. The PatchBot-test failed because there is no zlib.h.
The test includes 2 zlib-compressed pdb-files. They are needed for the test.
PatchBot-Log: https://testbot.winehq.org/JobDetails.pl?Key=45310#k101
Isn't it possible to use zlib.h for tests or did i something wrong?
Btw.: (Maybe a silly question ..) Is it possible to keep the original license header of this file (from reactos-project)?
/Andy
On 12/3/18 12:21 AM, Andreas Maier wrote:
Hello,
i've ported a test from the ReactOS-Project to wine. The PatchBot-test failed because there is no zlib.h.
Are you planning to submit it?
The test includes 2 zlib-compressed pdb-files. They are needed for the test.
PatchBot-Log: https://testbot.winehq.org/JobDetails.pl?Key=45310#k101
Isn't it possible to use zlib.h for tests or did i something wrong?
It should be possible to build and run tests on Windows as is. As I understand it your change will introduce runtime dependency?
Btw.: (Maybe a silly question ..) Is it possible to keep the original license header of this file (from reactos-project)?
I don't think so. Patch should be submitted under the same license the rest of Wine code is using.
+ /* TODO: Order is based on magic, should find entries based on name, and mark as 'seen' */ + { 0x1070, 36, SymTagFunction, "FfsFormat" }, + { 0x1010, 32, SymTagFunction, "DllMain" }, + { 0x1040, 36, SymTagFunction, "FfsChkdsk" },
+ { 0x2100, 0, SymTagPublicSymbol, "__IMPORT_DESCRIPTOR_ntdll" }, + { 0x109a, 0, SymTagPublicSymbol, "_DbgPrint" }, + { 0x2004, 0, SymTagPublicSymbol, "\x7fntdll_NULL_THUNK_DATA" }, + { 0x2000, 0, SymTagPublicSymbol, "__imp__DbgPrint" }, + { 0x2114, 0, SymTagPublicSymbol, "__NULL_IMPORT_DESCRIPTOR" },
Doesn't this depend on toolchain you used to build test dll?
It seems to be that fully functional pdb support will require much more tests like that, it might be better to keep them separate from wine tree.
/Andy
Hello Sivov, thanks for your reply.
On 03.12.2018 09:02, Nikolay Sivov wrote:
On 12/3/18 12:21 AM, Andreas Maier wrote:
Hello,
i've ported a test from the ReactOS-Project to wine. The PatchBot-test failed because there is no zlib.h.
Are you planning to submit it?
Yes, this was reason for porting it.
The test includes 2 zlib-compressed pdb-files. They are needed for the test.
PatchBot-Log: https://testbot.winehq.org/JobDetails.pl?Key=45310#k101
Isn't it possible to use zlib.h for tests or did i something wrong?
It should be possible to build and run tests on Windows as is. As I understand it your change will introduce runtime dependency?
Yes, to build this test i need this dependency or any other zib-tool.
Btw.: (Maybe a silly question ..) Is it possible to keep the original license header of this file (from reactos-project)?
I don't think so. Patch should be submitted under the same license the rest of Wine code is using.
+ /* TODO: Order is based on magic, should find entries based on name, and mark as 'seen' */ + { 0x1070, 36, SymTagFunction, "FfsFormat" }, + { 0x1010, 32, SymTagFunction, "DllMain" }, + { 0x1040, 36, SymTagFunction, "FfsChkdsk" },
+ { 0x2100, 0, SymTagPublicSymbol, "__IMPORT_DESCRIPTOR_ntdll" }, + { 0x109a, 0, SymTagPublicSymbol, "_DbgPrint" }, + { 0x2004, 0, SymTagPublicSymbol, "\x7fntdll_NULL_THUNK_DATA" }, + { 0x2000, 0, SymTagPublicSymbol, "__imp__DbgPrint" }, + { 0x2114, 0, SymTagPublicSymbol, "__NULL_IMPORT_DESCRIPTOR" },
Doesn't this depend on toolchain you used to build test dll?
I don't know.
It seems to be that fully functional pdb support will require much more tests like that, it might be better to keep them separate from wine tree.
Yes i think it might be better. I think wine does not really need pdb support .. right? So i will stop this work.
/Andy
-
Andreas Maier -
Nikolay Sivov