This quells one compiler warning I've been getting (with Clang, but GCC should warn as well).
Right now there are so many warnings, it's hard to find new or more serious ones.
Gerald --- dlls/windowscodecs/converter.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/dlls/windowscodecs/converter.c b/dlls/windowscodecs/converter.c index 0d7a3b745f..48cb3dcef2 100644 --- a/dlls/windowscodecs/converter.c +++ b/dlls/windowscodecs/converter.c @@ -84,13 +84,6 @@ typedef struct FormatConverter { CRITICAL_SECTION lock; /* must be held when initialized */ } FormatConverter;
-/* https://www.w3.org/Graphics/Color/srgb */ -static inline float from_sRGB_component(float f) -{ - if (f <= 0.04045f) return f / 12.92f; - return powf((f + 0.055f) / 1.055f, 2.4f); -} - static inline float to_sRGB_component(float f) { if (f <= 0.0031308f) return 12.92f * f; @@ -98,6 +91,13 @@ static inline float to_sRGB_component(float f) }
#if 0 /* FIXME: enable once needed */ +/* https://www.w3.org/Graphics/Color/srgb */ +static inline float from_sRGB_component(float f) +{ + if (f <= 0.04045f) return f / 12.92f; + return powf((f + 0.055f) / 1.055f, 2.4f); +} + static void from_sRGB(BYTE *bgr) { float r, g, b;
Gerald Pfeifer gerald@pfeifer.com wrote:
-/* https://www.w3.org/Graphics/Color/srgb */ -static inline float from_sRGB_component(float f) -{
- if (f <= 0.04045f) return f / 12.92f;
- return powf((f + 0.055f) / 1.055f, 2.4f);
-}
static inline float to_sRGB_component(float f) { if (f <= 0.0031308f) return 12.92f * f; @@ -98,6 +91,13 @@ static inline float to_sRGB_component(float f) }
#if 0 /* FIXME: enable once needed */ +/* https://www.w3.org/Graphics/Color/srgb */ +static inline float from_sRGB_component(float f) +{
- if (f <= 0.04045f) return f / 12.92f;
- return powf((f + 0.055f) / 1.055f, 2.4f);
+}
Please leave the comment where it is now, it belongs to all of these helpers, not just the moved one.