Re: msvcr: Added _crt_debugger_hook function

[Piotr Caban]

On 11/01/13 00:41, Andrey Zhezherun wrote:
> +/*********************************************************************
> -
> - _crt_debugger_hook (MSVCRT.@)
> - */
>
> +void CDECL MSVCRT__crt_debugger_hook(int reserved)
> +{
> - TRACE("");
>
> +}

The trace needs to end with '\n' character. Probably it's better to use 
ERR or FIXME here.

Why do you need this function? In all cases I've seen the function was 
called only when the application was working incorrectly.

Cheers,
Piotr

msvcr: Added _crt_debugger_hook function

[Andrey Zhezherun]

On 1 November 2013 09:47, Piotr Caban  wrote:
> The trace needs to end with '\n' character. Probably it's better to use ERR
> or FIXME here.

Fixed. This function doesn't need to do anything AFAIK so I'd rather
not print any extra warnings there.
> Why do you need this function? In all cases I've seen the function was
> called only when the application was working incorrectly.

Frankly I don't remember exactly now as I first wrote this patch a few
months ago. Perhaps I might have indeed been trying to debug a
crashing program that I was working on and saw an error related to
this function being called.

Regards,
Andrey