Re: [PATCH v2] ws2_32:Succeed IPV6_V6ONLY setsockopt for AF_INET sockets ignoring it

[Sebastian Lackner]

On 12.01.2017 06:27, Anton Romanov wrote:
> -
> -
>        bound = is_fd_bound(fd, &uaddr, &uaddrlen);
> -
>        release_sock_fd( s, fd );
> -
>        if (uaddr.addr.sa_family == AF_INET && bound == 0)

You might want to change the order here, uaddr is not initialized if
is_fd_bound fails.

[PATCH v2] ws2_32:Succeed IPV6_V6ONLY setsockopt for AF_INET sockets ignoring it

[Anton Romanov]

On Thu, Jan 12, 2017 at 7:13 AM, Sebastian Lackner
 wrote:
> On 12.01.2017 06:27, Anton Romanov wrote:
> > -
> > -
> >        bound = is_fd_bound(fd, &uaddr, &uaddrlen);
> > -
> >        release_sock_fd( s, fd );
> > -
> >        if (uaddr.addr.sa_family == AF_INET && bound == 0)
>
> You might want to change the order here, uaddr is not initialized if
> is_fd_bound fails.

Sure, sent a new version.