Re: [1/7] gdi32: Relax vertical face requirements.

[Dmitry Timoshkov]

Akihiro Sagawa  wrote:
> --- a/dlls/gdi32/freetype.c
> +++ b/dlls/gdi32/freetype.c
> @@ -2148,6 +2148,9 @@ static INT AddFontToList(const char *file, void *font_data_ptr, DWORD font_data_
>  #endif /* HAVE_CARBON_CARBON_H */
>  do {
> -
>    const DWORD DBCS_MASK = 0x3e0000;

dlls/gdi32/font.c,GetFontLanguageInfo() defines DBCS_MASK as 0x3f0000,
I'd guess that one of these places needs to be fixed.

[1/7] gdi32: Relax vertical face requirements.

[Akihiro Sagawa]

On Sat, 4 Jan 2014 20:02:35 +0900, Dmitry Timoshkov wrote:
> > -
> >    const DWORD DBCS_MASK = 0x3e0000;
>
> dlls/gdi32/font.c,GetFontLanguageInfo() defines DBCS_MASK as 0x3f0000,
> I'd guess that one of these places needs to be fixed.

Good point. I think Wine's GetFontLanaguageInfo needs to update. There
are two reasons.
Firstly, GetFontLanguageInfo()'s DBCS_MASK is not suitable for DBCS and
vertical writing. Because 0x3f0000 sets bit 16 (0x10000), that is Thai
charset.
Secondly, I tested native GetFontLanguageInfo(). The result[1] shows
even DBCS font, like MS Gothic, doesn't return GCP_MBCS flag.

I've not figure out what condition is needed for GCP_DBCS yet. If you
have a good idea, could you let me know. Thanks in advance.

[1] http://newtestbot.winehq.org/JobDetails.pl?Key=4002&log_206=1#k206
    font.c:5993 is an additional test for GCP_xxx flags

Regards,
Akihiro