Re: [PATCH] msvcrt: Implement nan

[Piotr Caban]

On 01/14/17 00:11, Daniel Lehman wrote:
> +double CDECL MSVCR120_nan(const char *tagp)
> +{
> - /* Windows ignores input (MSDN) and Linux crashes on NULL */
> - const char *dummy = "NAN";
>
> +#ifdef HAVE_NAN
> - return nan(dummy);
>
> +#else
> - return strtod(dummy, NULL);
>
> +#endif
> +}

Why can't you just "return NAN;" here?

Thanks,
Piotr

[PATCH] msvcrt: Implement nan

[Daniel Lehman]

> Why can't you just "return NAN;" here?

I was following the pattern of forwarding for other math functions and the man page for nan

But returning NAN is simpler.  I'll submit a new patch