Re: [PATCH] wined3d: Implement SM5 bfrev opcode in glsl.

[Józef Kucia]

On Fri, Jul 15, 2016 at 1:25 PM, Guillaume Charifi
 wrote:
> Signed-off-by: Guillaume Charifi
>
> dlls/wined3d/glsl_shader.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/dlls/wined3d/glsl_shader.c b/dlls/wined3d/glsl_shader.c
> index 5e23920..376d110 100644
> --- a/dlls/wined3d/glsl_shader.c
> +++ b/dlls/wined3d/glsl_shader.c
> @@ -3538,6 +3538,7 @@ static void shader_glsl_map2gl(const struct wined3d_shader_instruction *ins)
>          case WINED3DSIH_ROUND_Z: instruction = "trunc"; break;
>          case WINED3DSIH_SQRT: instruction = "sqrt"; break;
>          case WINED3DSIH_UMAX: instruction = "max"; break;
> -
>    case WINED3DSIH_BFREV: instruction = "bitfieldReverse"; break;

I think this requires you to enable appriopriate extension in GLSL
(GL_ARB_gpu_shader5, in this case). I haven't looked closely at the
other patches but they seem to have the same issue.

[PATCH] wined3d: Implement SM5 bfrev opcode in glsl.

[Henri Verbeet]

On 15 July 2016 at 13:59, Józef Kucia  wrote:
> On Fri, Jul 15, 2016 at 1:25 PM, Guillaume Charifi
>  wrote:
> > Signed-off-by: Guillaume Charifi
> >
> > dlls/wined3d/glsl_shader.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/dlls/wined3d/glsl_shader.c b/dlls/wined3d/glsl_shader.c
> > index 5e23920..376d110 100644
> > --- a/dlls/wined3d/glsl_shader.c
> > +++ b/dlls/wined3d/glsl_shader.c
> > @@ -3538,6 +3538,7 @@ static void shader_glsl_map2gl(const struct wined3d_shader_instruction *ins)
> >          case WINED3DSIH_ROUND_Z: instruction = "trunc"; break;
> >          case WINED3DSIH_SQRT: instruction = "sqrt"; break;
> >          case WINED3DSIH_UMAX: instruction = "max"; break;
> > -
> >    case WINED3DSIH_BFREV: instruction = "bitfieldReverse"; break;
>
> I think this requires you to enable appriopriate extension in GLSL
> (GL_ARB_gpu_shader5, in this case). I haven't looked closely at the
> other patches but they seem to have the same issue.

Yeah, although the plan was to require GLSL 4.30 for shader model 5,
which would have the various bitfield operations.
I think this raises questions about how these patches were validated.