Re: Reinhard Karcher : user32: Speed improvement for 16bit comm support.

[Robert Shearman]

Alexandre Julliard wrote:
> Module: wine
> Branch: master
> Commit: dff43b732b10e603f3aee38db2f684dc7404aa4e
> URL:    http://source.winehq.org/git/wine.git/?a=commit;h=dff43b732b10e603f3aee38db2...
>
> Author: Reinhard Karcher 
> Date:   Mon Jan  1 17:45:06 2007 +0100
>
> user32: Speed improvement for 16bit comm support.
>
> dlls/user32/comm16.c |    5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/dlls/user32/comm16.c b/dlls/user32/comm16.c
> index 9329c82..0164196 100644
> --- a/dlls/user32/comm16.c
> +++ b/dlls/user32/comm16.c
> @@ -719,9 +719,8 @@ INT16 WINAPI GetCommError16(INT16 cid,LP
>          stol = (unsigned char *)COM[cid].unknown + COMM_MSR_OFFSET;
>    COMM_MSRUpdate( ptr->handle, stol );
> - if (lpStat) {
> -
> lpStat->status = 0;
> -
> -
>   if (lpStat) {
> -
>           lpStat->status = 0;
>
> SleepEx(1,TRUE);
>
> lpStat->cbOutQue = comm_outbuf(ptr);

This patch doesn't seem to do what it says it does.

Reinhard Karcher : user32: Speed improvement for 16bit comm support.

[Alexandre Julliard]

Robert Shearman  writes:
> > diff --git a/dlls/user32/comm16.c b/dlls/user32/comm16.c
> > index 9329c82..0164196 100644
> > --- a/dlls/user32/comm16.c
> > +++ b/dlls/user32/comm16.c
> > @@ -719,9 +719,8 @@ INT16 WINAPI GetCommError16(INT16 cid,LP
> >          stol = (unsigned char *)COM[cid].unknown + COMM_MSR_OFFSET;
> >    COMM_MSRUpdate( ptr->handle, stol );
> > - if (lpStat) {
> > -
> > lpStat->status = 0;
> > -
> > -
> >   if (lpStat) {
> > -
> >           lpStat->status = 0;
> > SleepEx(1,TRUE);
> >   lpStat->cbOutQue = comm_outbuf(ptr);
>
> This patch doesn't seem to do what it says it does.

Indeed, thanks for spotting this. It's the second time this happens,
it seems that Emacs diff mode cannot be trusted to apply hunks
correctly :-(