This output can interfere with shell/wcmd processes, or at least make them harder to use. If we put every todo item in a fixme wine would be unusable anyway :)
Mike Hearn mh@codeweavers.com Replace SetConsoleCtrlHandler fixme with a comment
Index: dlls/kernel/console.c =================================================================== RCS file: /home/wine/wine/dlls/kernel/console.c,v retrieving revision 1.26 diff -u -r1.26 console.c --- dlls/kernel/console.c 11 Mar 2004 22:46:27 -0000 1.26 +++ dlls/kernel/console.c 15 Mar 2004 13:44:22 -0000 @@ -1427,7 +1427,7 @@ { BOOL ret = TRUE;
- FIXME("(%p,%i) - no error checking or testing yet\n", func, add); + /* FIXME: no error checking or testing yet */
if (!func) {
Mike Hearn a écrit :
This output can interfere with shell/wcmd processes, or at least make them harder to use. If we put every todo item in a fixme wine would be unusable anyway :)
if you don't fix the fixme, it will also be unusable. So, it has been put there some reasons: don't fix the consequences, fix the cause !!!
A+
On Mon, 2004-03-15 at 19:39, Eric Pouech wrote:
if you don't fix the fixme, it will also be unusable. So, it has been put there some reasons: don't fix the consequences, fix the cause !!!
Well, there are a whole ton of things that lack proper error checking etc in Wine - if we used a fixme for all of them Wine would spend all its time printing fixmes and no time running! I know what you mean, but in this case I feel it's better as a todo in the source rather than something the user must always see.
thanks -mike
-
Eric Pouech -
Mike Hearn