Re: [PATCH 3/5] server: Get and set the console ColorTable

[Alexandre Julliard]

Hugh McMaster  writes:
> @@ -1568,6 +1568,22 @@ struct console_renderer_event
>      short int    font_height;
>  @END
> -
>
> +/* Fill the console ColorTable */
> +@REQ(set_console_colortable)
> - obj_handle_t handle;        /* handle to the console */
> - VARARG(color,unsigned_int); /* ColorTable */
>
> +@END
> -
> -
>
> +/* Fetch the console ColorTable */
> +@REQ(get_console_colortable)
> - obj_handle_t handle;        /* handle to the console */
>
> +@REPLY
> - VARARG(color,unsigned_int); /* ColorTable */
>
> +@END

It would probably be better to add this to the existing
get/set_console_output_info requests.

[PATCH 3/5] server: Get and set the console ColorTable

[Hugh McMaster]

On Tuesday, 9 August 2016 12:58 PM, Alexandre Julliard wrote:
> Hugh McMaster  writes:
> > @@ -1568,6 +1568,22 @@ struct console_renderer_event
> >       short int    font_height;
> >   @END
> > -
> >
> > +/* Fill the console ColorTable */
> > +@REQ(set_console_colortable)
> > +    obj_handle_t handle;        /* handle to the console */
> > +    VARARG(color,unsigned_int); /* ColorTable */
> > +@END
> > -
> > -
> >
> > +/* Fetch the console ColorTable */
> > +@REQ(get_console_colortable)
> > +    obj_handle_t handle;        /* handle to the console */
> > +@REPLY
> > +    VARARG(color,unsigned_int); /* ColorTable */
> > +@END
>
> It would probably be better to add this to the existing
> get/set_console_output_info requests.

screen_buffer->color_map[16] has a byte size of 64. Wouldn't that cause problems with the maximum server
request/reply size in functions such as Get/SetConsoleScreenBufferInfoEx?

[PATCH 3/5] server: Get and set the console ColorTable

[Alexandre Julliard]

Hugh McMaster  writes:
> On Tuesday, 9 August 2016 12:58 PM, Alexandre Julliard wrote:
> > Hugh McMaster  writes:
> > > @@ -1568,6 +1568,22 @@ struct console_renderer_event
> > >       short int    font_height;
> > >   @END
> > > -
> > >
> > > +/* Fill the console ColorTable */
> > > +@REQ(set_console_colortable)
> > > +    obj_handle_t handle;        /* handle to the console */
> > > +    VARARG(color,unsigned_int); /* ColorTable */
> > > +@END
> > > -
> > > -
> > >
> > > +/* Fetch the console ColorTable */
> > > +@REQ(get_console_colortable)
> > > +    obj_handle_t handle;        /* handle to the console */
> > > +@REPLY
> > > +    VARARG(color,unsigned_int); /* ColorTable */
> > > +@END
> >
> > It would probably be better to add this to the existing
> > get/set_console_output_info requests.
>
> screen_buffer->color_map[16] has a byte size of 64. Wouldn't that cause problems with the maximum server
> request/reply size in functions such as Get/SetConsoleScreenBufferInfoEx?

It has to be in the VARARG data, but that's what you are doing already.