Re: [PATCH 3/3] dmsynth: Put port caps that match native ones.

[Andrew Eikum]

Just to be clear, which "native" do you mean? Does this match Windows
7's dmusic behavior, or something else? I've been trying to target
Windows 7's behavior in the new audio design.

Also...

On Thu, Mar 29, 2012 at 08:53:52AM +0200, Christian Costa wrote:
> - obj->pCaps.dwEffectFlags = DMUS_EFFECT_REVERB | DMUS_EFFECT_CHORUS | DMUS_EFFECT_DELAY;
> - obj->pCaps.dwEffectFlags = DMUS_EFFECT_REVERB; /* DMUS_EFFECT_CHORUS | DMUS_EFFECT_DELAY */

I'd just remove the unused flags. No need for crufty comments.

[PATCH 3/3] dmsynth: Put port caps that match native ones.

[Christian Costa]

2012/3/29 Andrew Eikum
> Just to be clear, which "native" do you mean? Does this match Windows
> 7's dmusic behavior, or something else? I've been trying to target
> Windows 7's behavior in the new audio design.

They're recents but I don't remember. I will check this evening. I didn't
know about Windows 7 target but I'm ok with that so I will aligned if
needed.
> Also...
>
> On Thu, Mar 29, 2012 at 08:53:52AM +0200, Christian Costa wrote:
> > -
> > obj->pCaps.dwEffectFlags = DMUS_EFFECT_REVERB | DMUS_EFFECT_CHORUS
>
> | DMUS_EFFECT_DELAY;
> > -
> > obj->pCaps.dwEffectFlags = DMUS_EFFECT_REVERB; /*
>
> DMUS_EFFECT_CHORUS | DMUS_EFFECT_DELAY */
>
> I'd just remove the unused flags. No need for crufty comments.

Ok I will remove them.