I've just applied/built/installed/tested the U series patches, and I have 2 regressions in the AAA MapNGo program:
First, the first column of the directions window (which shows the type of road) is missing.
Second, when I do the "Along the way", the program cores out.
The log, and a screen cap showing (or rather, NOT showing) the missing field in the directions window, are in a tarball:
On October 19, 2002 11:34 am, David D. Hagood wrote:
I've just applied/built/installed/tested the U series patches, and I have 2 regressions in the AAA MapNGo program:
First, the first column of the directions window (which shows the type of road) is missing.
U3 should fix this, please give it a try.
Second, when I do the "Along the way", the program cores out.
That's not a regression, it's a showcased bug! :))) I'll look into it.
On October 19, 2002 11:34 am, David D. Hagood wrote:
Second, when I do the "Along the way", the program cores out.
This one's tricky. Can you please retest (it will still crash), and send me the log, after applying thing patch:
--- dlls/comctl32/listview.c.V0 Sat Oct 19 17:49:34 2002 +++ dlls/comctl32/listview.c Sat Oct 19 18:21:55 2002 @@ -5678,12 +5678,14 @@ is_sorted = (lStyle & (LVS_SORTASCENDING | LVS_SORTDESCENDING)) && !(lStyle & LVS_OWNERDRAWFIXED) && (LPSTR_TEXTCALLBACKW != lpLVItem->pszText);
- nItem = DPA_InsertPtr( infoPtr->hdpaItems, - is_sorted ? infoPtr->nItemCount + 1 : lpLVItem->iItem, - hdpaSubItems ); + nItem = is_sorted ? infoPtr->nItemCount + 1 : lpLVItem->iItem; + TRACE(" inserting at %d, sorted=%d, count=%d, iItem=%d\n", nItem, is_sorted, infoPtr->nItemCount, lpLVItem->iItem); + nItem = DPA_InsertPtr( infoPtr->hdpaItems, nItem, hdpaSubItems ); + TRACE(" result of insert is %d\n", nItem); if (nItem == -1) goto fail; /* the array may be sparsly populated, we can't just increment the count here */ infoPtr->nItemCount = infoPtr->hdpaItems->nItemCount; + TRACE(" item count is %d\n", infoPtr->nItemCount);
/* set the item attributes */ if (!set_main_item(infoPtr, lpLVItem, TRUE, isW, &has_changed)) goto undo;
Dimitrie O. Paun wrote:
On October 19, 2002 11:34 am, David D. Hagood wrote:
Second, when I do the "Along the way", the program cores out.
This one's tricky. Can you please retest (it will still crash), and send me the log, after applying thing patch:
The patch is not applying - Is this supposed to apply to the current CVS, or to the current patch set (including V0)?
Dimitrie O. Paun wrote:
On October 19, 2002 11:34 am, David D. Hagood wrote:
Second, when I do the "Along the way", the program cores out.
This one's tricky. Can you please retest (it will still crash), and send me the log, after applying thing patch:
Wiggled the patch in. I've attached the log.
On October 19, 2002 09:23 pm, David D. Hagood wrote:
Wiggled the patch in. I've attached the log.
I found the bug. It's in the DPA_{Set,Insert}Ptr functions, not in the listview. It's amazing it worked, as it did, with such a big bug in. I'm going out now for a few hours, will fix when I get back.
On October 19, 2002 11:03 pm, Dimitrie O. Paun wrote:
On October 19, 2002 09:23 pm, David D. Hagood wrote:
Wiggled the patch in. I've attached the log.
I found the bug. It's in the DPA_{Set,Insert}Ptr functions, not in the listview.
OK, please try the DPA_InsertPtr patch I've just sent to wine-patches. If it doesn't work, please send me a trace.
Dimitrie O. Paun wrote:
OK, please try the DPA_InsertPtr patch I've just sent to wine-patches. If it doesn't work, please send me a trace.
Better, but not all the way. It doesn't crash, and *some* of the items show up in the "along the way" box, but not all.
Log and PNG at
http://sktc.net/~wowbagger/listview4.tar.gz
I also get the same result with the V1 and V2 patches in place.
On October 20, 2002 09:35 am, David D. Hagood wrote:
Better, but not all the way. It doesn't crash, and *some* of the items show up in the "along the way" box, but not all.
Please try V4, it should fix it. If not, a trace is appreciated, as always. :)
By George I Think He's Got It!
The "Along the way" dialog works perfectly now.
On October 20, 2002 03:19 pm, David D. Hagood wrote:
The "Along the way" dialog works perfectly now.
Yay!!!!!!!!!!!!!!!!!! :)
-
David D. Hagood -
Dimitrie O. Paun