This patch is for https://bugs.winehq.org/show_bug.cgi?id=33492, already tested as working.
I wanted to send for review first, as I'm not sure if this is the best approach or if someone has a better idea for how to handle it.
Thanks,
On 26.04.2016 9:18, Austin English wrote:
This patch is for https://bugs.winehq.org/show_bug.cgi?id=33492, already tested as working.
I wanted to send for review first, as I'm not sure if this is the best approach or if someone has a better idea for how to handle it.
Thanks,
Isn't it enough to have empty [fonts] section created on prefix creation? On Win7 installation I don't see SystemFont entries there, only empty section. So the question is do we ever have to update it, and if yes, what is it updated with? If it's static strings, having gdi32 do that looks wrong.
On Tue, Apr 26, 2016 at 1:57 AM, Nikolay Sivov bunglehead@gmail.com wrote:
On 26.04.2016 9:18, Austin English wrote:
This patch is for https://bugs.winehq.org/show_bug.cgi?id=33492, already tested as working.
I wanted to send for review first, as I'm not sure if this is the best approach or if someone has a better idea for how to handle it.
Thanks,
Isn't it enough to have empty [fonts] section created on prefix creation? On Win7 installation I don't see SystemFont entries there, only empty section. So the question is do we ever have to update it, and if yes, what is it updated with? If it's static strings, having gdi32 do that looks wrong.
Empty would be enough, but I wasn't able to get WriteProfileSectionW() to write an empty section.
I haven't been able to find an example of what should be in there online, and I don't have any old 9x machines. XP is blank as well.
I originally had it in kernel32, but moved to gdi32 since I thought it may end up enumerating fonts. I suppose I should move back to kernel32 and try to get an empty section to work.
Thanks for looking.