Test if button is drawn properly

[Fabian Maurer]

Hello,

I'm currently investigating https://bugs.winehq.org/show_bug.cgi?id=45246.

in comctl32/button.c in BUTTON_CalcLabelRect:
> if ((infoPtr->u.image && bm.bmWidth == 0 && bm.bmHeight == 0)
>        || (text == NULL || text[0] == '\0'))

This causes the button not to render when an image is set, but the text is null. 
AFAIK a button can have only an image though - handling it like that fixes a 
rendering issue.
But how can I write a test for that, to document that behavior?

Regards,
Fabian Maurer

[Zhiyi Zhang]

Hi Fabian,

The functionality to show both image and text patch got delayed.
and is being reviewed. Right now if an image is set, then it
shows an image.

I'm afraid there is no easy and reliable way to test ui automatically.
You can test it manually though.

Thanks,
Zhiyi

#ref:https://msdn.microsoft.com/en-us/library/windows/desktop/bb761822(v=vs.85).a...

On Thu 5 31 9:23, Fabian Maurer wrote:
> Hello,
>
> I'm currently investigating https://bugs.winehq.org/show_bug.cgi?id=45246.
>
> in comctl32/button.c in BUTTON_CalcLabelRect:
> > if ((infoPtr->u.image && bm.bmWidth == 0 && bm.bmHeight == 0)
> >        || (text == NULL || text[0] == '\0'))
>
> This causes the button not to render when an image is set, but the text is null. 
> AFAIK a button can have only an image though - handling it like that fixes a 
> rendering issue.
> But how can I write a test for that, to document that behavior?
>
> Regards,
> Fabian Maurer

[Fabian Maurer]

> I'm afraid there is no easy and reliable way to test ui automatically.
> You can test it manually though.

Okay, makes sense.
> The functionality to show both image and text patch got delayed.
> and is being reviewed. Right now if an image is set, then it
> shows an image.

Mind linking the patch?
It only shows an image if the text also is not null, what is kinda odd. Does the patch 
also address that?

Regards,
Fabian Maurer