Re: add ualapi directory (try 11)

[Marcus Meissner]

On Sat, Sep 28, 2013 at 11:58:33AM +0900, Akira Nakagawa wrote:
>
> From 2ecc71fdb3406d3cf79ebcbd7f6d0c711b68d699 Mon Sep 17 00:00:00 2001
> Message-Id: 
> From: Akira Nakagawa 
> Date: Mon, 23 Sep 2013 17:00:04 +0900
> Subject: [PATCH] add ual directory (try9)
>
> configure                       |  2 +

Not needed to be submitted
> configure.ac                    |  2 +

also not actually needed as these parts are autogenerated.
> dlls/ualapi/Makefile.in         |  6 +++
>  dlls/ualapi/main.c              | 86 +++++++++++++++++++++++++++++++++++++++++
> dlls/ualapi/tests/Makefile.in   |  8 ++++
>  dlls/ualapi/tests/ualapi_test.c | 38 ++++++++++++++++++

You have no working tests yet, so leave these two files out. 
Add them with the patch with the first tests.
> dlls/ualapi/ualapi.spec         |  4 ++
> include/Makefile.in             |  1 +

include/Makefile.in is also autoadjusted.
> include/ual.h                   | 48 +++++++++++++++++++++++
>  9 files changed, 195 insertions(+)

rest looks ok, but you really only should submit:

dlls/ualapi/Makefile.in
    dlls/ualapi/main.c
    dlls/ualapi/ualapi.spec
    include/ual.h

as the rest are autogenerated.

Ciao, Marcus

add ualapi directory (try 11)

[Henri Verbeet]

On 28 September 2013 09:35, Marcus Meissner  wrote:
> rest looks ok, but you really only should submit:

I don't think it does, it still has e.g. the modified copyright
headers I pointed out when this was still at try 1.