Re: [PATCH 3/4] d3dx9/tests: Add tests for DDS file format size validation.

[Matteo Bruni]

2015-08-16 22:28 GMT+02:00 Józef Kucia :
> dlls/d3dx9_36/tests/surface.c | 172 ++++++++++++++++++++++++++++--------------
>  1 file changed, 116 insertions(+), 56 deletions(-)
>
> diff --git a/dlls/d3dx9_36/tests/surface.c b/dlls/d3dx9_36/tests/surface.c
> index 7a4dff8..9da3628 100644
> --- a/dlls/d3dx9_36/tests/surface.c
> +++ b/dlls/d3dx9_36/tests/surface.c
> -
>    { { 32, DDS_PF_RGB, 0, 24, 0xff0000, 0x00ff00, 0x0000ff, 0x000000 }, DDS_MIPMAPCOUNT, 256, 256, 0, 0, 196607, { D3DXERR_INVALIDDATA, 0 } },
> -
>    { { 32, DDS_PF_RGB, 0, 24, 0xff0000, 0x00ff00, 0x0000ff, 0x000000 }, DDS_MIPMAPCOUNT, 256, 256, 0, 0, 196608, { D3D_OK, 1 } },

I would add another test for DDS_MIPMAPCOUNT with a count of 0 but a
larger data size. I wonder if 0 actually means something like "as many
levels as they fit in the file".