On 2001.10.21 18:34 David Elliott wrote:
This one should properly implement all of the Uuid*String[AW] functions in RPCRT4.DLL
NOTE, this includes a bugfix to the existing UuidToStringA in that it does not allocate enough space to store the string it outputs. (it is short by 2 chars).
-Dave
Noticed that Alexandre applied my NTDLL patch, but not this one.
Hmm, now that I am looking at this I guess the swprintf is defined in NTDLL so I should just use that... WHOOPS, did a lot more coding than I had to.
I will rework this to use the much saner method and resend the patch later tonight.
Oh well, at least we got a free implementation of wcstoul out of it. :-)
If I am on the wrong track here, lemme know. Originally I had thought that something like a printf function would only be declared in MSVCRT and didn't want to import that, but now that I am looking at it it seems that MSVCRT only forwards to NTDLL.
Gotta get out of that UNIX mindset and into the windows one I guess.
-Dave
On Mon, 22 Oct 2001, David Elliott wrote: [...]
Hmm, now that I am looking at this I guess the swprintf is defined in NTDLL so I should just use that... WHOOPS, did a lot more coding than I had to.
I will rework this to use the much saner method and resend the patch later tonight.
Oh well, at least we got a free implementation of wcstoul out of it. :-)
If I am on the wrong track here, lemme know. Originally I had thought that something like a printf function would only be declared in MSVCRT and didn't want to import that, but now that I am looking at it it seems that MSVCRT only forwards to NTDLL.
Actually there's quite a few *printf implementations in the Wine tree. Too many I would say. What's more, IIRC most of them are incomplete as they do not support %S and %C (Unicode for ANSI printfs, ANSI for Unicode printfs). I believe this whole thing needs a good cleanup... Ah, I knew I had entered a bug report for that one: http://wine.codeweavers.com/bugzilla/show_bug.cgi?id=321
sscanf too may need some cleaning. Any volunteers?
Gotta get out of that UNIX mindset and into the windows one I guess.
Preferably not ;-)
-- Francois Gouget fgouget@free.fr http://fgouget.free.fr/ Any sufficiently advanced Operating System is indistinguishable from Linux
On 2001.10.22 18:28 Francois Gouget wrote:
On Mon, 22 Oct 2001, David Elliott wrote: [...]
Hmm, now that I am looking at this I guess the swprintf is defined in
NTDLL
so I should just use that... WHOOPS, did a lot more coding than I had
to.
I will rework this to use the much saner method and resend the patch
later
tonight.
Oh well, at least we got a free implementation of wcstoul out of it.
:-)
If I am on the wrong track here, lemme know. Originally I had thought
that
something like a printf function would only be declared in MSVCRT and didn't want to import that, but now that I am looking at it it seems
that
MSVCRT only forwards to NTDLL.
Actually there's quite a few *printf implementations in the Wine tree. Too many I would say. What's more, IIRC most of them are incomplete as they do not support %S and %C (Unicode for ANSI printfs, ANSI for Unicode printfs). I believe this whole thing needs a good cleanup... Ah, I knew I had entered a bug report for that one: http://wine.codeweavers.com/bugzilla/show_bug.cgi?id=321
sscanf too may need some cleaning. Any volunteers?
Yes. I am good at stuff like this. It's easy, you look at the manpage and implement it, and then go back and put in MS hacks. No design involved there or trying to figure out MSes crappy design since it uses normal POSIX semantics.
Besides, a mostly working sscanf/sprintf (both normal and unicode) is kind of a requirement to write these functions correctly rather than rewrite part of sscanf as I did.
Gotta get out of that UNIX mindset and into the windows one I guess.
Preferably not ;-)
:-) True, but on the other hand I believe the higher level libraries should not require calling into POSIX unless absolutely necessary; i.e. being able to take a wine dll, compile it into a PE DLL and use it in real Windows would be kind of a cool thing. Obviously this is not possible everywhere, but for these particular RPCRT4 functions I see no reason why they should require more than what NTDLL provides (since NTDLL seems to provide basically everything, at least if it was completely implemented).
-- Francois Gouget fgouget@free.fr http://fgouget.free.fr/ Any sufficiently advanced Operating System is indistinguishable from Linux
What's the corrolary to that. Any crappy OS or GUI is indistinguishable from Windows? Should I dare say "See KDE for an example." :-/
-Dave
On Tue, 23 Oct 2001, David Elliott wrote: [...]
Actually there's quite a few *printf implementations in the Wine tree. Too many I would say. What's more, IIRC most of them are incomplete as they do not support %S and %C (Unicode for ANSI printfs, ANSI for Unicode printfs). I believe this whole thing needs a good cleanup... Ah, I knew I had entered a bug report for that one: http://wine.codeweavers.com/bugzilla/show_bug.cgi?id=321
sscanf too may need some cleaning. Any volunteers?
Yes. I am good at stuff like this. It's easy, you look at the manpage and implement it, and then go back and put in MS hacks. No design involved there or trying to figure out MSes crappy design since it uses normal POSIX semantics.
Excellent. The lack of a %S bothered me when I tried to test CommandLineToArgvW but I did not have time to fix it. The next step will be to get a working getws :-)
-- Francois Gouget fgouget@free.fr http://fgouget.free.fr/ Hiroshima '45 - Czernobyl '86 - Windows '95
-
David Elliott -
Francois Gouget