Re: [1/2] kernel32: Add a test for protections accepted by CreateFileMapping, make it pass under Wine.

[Alexandre Julliard]

Dmitry Timoshkov  writes:
> @@ -350,9 +350,6 @@ HANDLE WINAPI CreateFileMappingW( HANDLE hFile, LPSECURITY_ATTRIBUTES sa,
>  switch(protect)
>  {
> - case 0:
> -
>    protect = PAGE_READONLY;  /* Win9x compatibility */
> -
>    /* fall through */

Did you try your test on Win9x?

[1/2] kernel32: Add a test for protections accepted by CreateFileMapping, make it pass under Wine.

[Dmitry Timoshkov]

Alexandre Julliard  wrote:
> > @@ -350,9 +350,6 @@ HANDLE WINAPI CreateFileMappingW( HANDLE hFile, LPSECURITY_ATTRIBUTES sa,
> >  switch(protect)
> >  {
> > - case 0:
> > -
> >    protect = PAGE_READONLY;  /* Win9x compatibility */
> > -
> >    /* fall through */
>
> Did you try your test on Win9x?

No, i have no a win9x machine around.

[1/2] kernel32: Add a test for protections accepted by CreateFileMapping, make it pass under Wine.

[Alexandre Julliard]

Dmitry Timoshkov  writes:
> Alexandre Julliard  wrote:
> > > @@ -350,9 +350,6 @@ HANDLE WINAPI CreateFileMappingW( HANDLE hFile, LPSECURITY_ATTRIBUTES sa,
> > >  switch(protect)
> > >  {
> > > - case 0:
> > > -
> > >    protect = PAGE_READONLY;  /* Win9x compatibility */
> > > -
> > >    /* fall through */
> >
> > Did you try your test on Win9x?
>
> No, i have no a win9x machine around.

Hmmm, we should keep one available on the testbot for cases like this.

[1/2] kernel32: Add a test for protections accepted by CreateFileMapping, make it pass under Wine.

[Francois Gouget]

Here is what I get on Windows Millenium.

[1/2] kernel32: Add a test for protections accepted by CreateFileMapping, make it pass under Wine.

[Dmitry Timoshkov]

Francois Gouget  wrote:
> Here is what I get on Windows Millenium.

Many thanks, but creation of the temp file has failed for some reason (probably
because of GENERIC_EXECUTE), and that invalidates the test results:

virtual.c:1687: Test failed: CreateFile(C:\WINDOWS\TEMP\map60F4.TMP) error 87

Could you please try to remove GENERIC_EXECUTE from the CreateFile call and
try again?

[1/2] kernel32: Add a test for protections accepted by CreateFileMapping, make it pass under Wine.

[Francois Gouget]

On Mon, 28 Nov 2011, Dmitry Timoshkov wrote:
[...]
> Could you please try to remove GENERIC_EXECUTE from the CreateFile call and
> try again?

Heer is the adjusted patch and corresponding log (still on Windows 
Millenium).

[1/2] kernel32: Add a test for protections accepted by CreateFileMapping, make it pass under Wine.

[Dmitry Timoshkov]

Francois Gouget  wrote:
> Heer is the adjusted patch and corresponding log (still on Windows 
> Millenium).
> virtual.c:1744: Test failed: 0: CreateFileMapping should fail
> virtual.c:1745: Test failed: 0: expected ERROR_INVALID_PARAMETER, got 0

Thanks. Apparently CreateFileMapping never fails under Win9x, but Wine has
a workaround only for protect == 0 at the moment, and there are not much
complaints about that.

I'll add a workaround for the test with protect = 0 being running with
emulated version set to win9x, hopefully that will be enough.

Thanks once again.