Integer overflow problem in string::compare()

[Dan Kegel]

Hi Piotr,
could you review the patch in http://bugs.winehq.org/show_bug.cgi?id=31085 ?
If you like it, I'll submit it to wine-patches.  It passes winetestbot and
gets pulsen and stepmania past the splash screen abort.

Why are there no tests for msvcp60?
If you think it's appropriate, I can add the fix and test for msvcp60 as well.

Thanks for all your hard work!
- Dan

[Piotr Caban]

Hi,

On 07/02/12 04:13, Dan Kegel wrote:
> could you review the patch in http://bugs.winehq.org/show_bug.cgi?id=31085 ?
> If you like it, I'll submit it to wine-patches.  It passes winetestbot and
> gets pulsen and stepmania past the splash screen abort.

This patch looks correct. It's also good to fix other functions with 
similar bug.
> Why are there no tests for msvcp60?

There's no reason for not having msvcp60 tests. msvcp90 also lacks a lot 
of tests.
> If you think it's appropriate, I can add the fix and test for msvcp60 as well.

It's good to fix it in msvcp60 as well.

Cheers,
Piotr

[Dan Kegel]

On Mon, Jul 2, 2012 at 2:51 AM, Piotr Caban  wrote:
> This patch looks correct. It's also good to fix other functions with similar
> bug.

Great, I'll have a bigger patchset for review in a few days.

Thanks,
Dan