Re: Patch 1/2 for SmartForms Installer: PROFILE_GetString incorrect return value

[Andreas Mohr]

On Sat, Jun 22, 2002 at 12:18:07AM -0400, Joshua Thielen wrote:
> This patch fixes an error encountered in the Smart Forms installer 
> (somewhat related to bug 575).
>
> When calling GetPrivateProfileString with the second parameter as NULL, 
> all of the keys under the specified section are copied to the buffer. 
> The return value should be the number of characters copied minus the 
> last null terminator. Since the keys are copied as null-terminated 
> strings with the last string terminated with two null characters, strlen 
> cannot be used to determine the number of characters copied. This patch 
> corrects PROFILE_GetString for this case.

Hmm, hmm. Could this happen to fix bug #724 also ?
Word97 etc. broke when I handled the "default" case in PROFILE_GetString().
As the log files received didn't show relay lines, only profile lines,
I haven't been able to fix it.
But this sounds like a reasonable cause for it...

Patch 1/2 for SmartForms Installer: PROFILE_GetString incorrect return value

[Joshua Thielen]

> Hmm, hmm. Could this happen to fix bug #724 also ?
> Word97 etc. broke when I handled the "default" case in PROFILE_GetString().
> As the log files received didn't show relay lines, only profile lines,
> I haven't been able to fix it.
> But this sounds like a reasonable cause for it...

Well, based on the bug description, I'd say it probably does. The 
SmartForms installer failed because the SFSERV.DLLcould not be found 
(needed by SFSETUP.EXE). In the INI file, SETUP.LST, the Params section 
contains a list of files to be uncompressed to the temporary directory 
~SFSETUP. Since GetProfileString returned only the number of characters 
in the first string, the installer only copied the installer executable 
SFSETUP.EXE but not the necessary supporting files (DLLs, etc). This 
sounds very similar to the problem reported in bug 724.

Josh