Re: winecfg: Let the user specify the drive letter of a to be added drive.

[Austin English]

On Sun, Aug 16, 2009 at 1:12 PM, Rein Klazes wrote:
> fixes bug#14728
>
> programs/winecfg/Bg.rc      |   10 +++++++++
>  programs/winecfg/Cs.rc      |   10 +++++++++
>  programs/winecfg/Da.rc      |   10 +++++++++
>  programs/winecfg/De.rc      |   10 +++++++++
>  programs/winecfg/En.rc      |   10 +++++++++
>  programs/winecfg/Es.rc      |   10 +++++++++
>  programs/winecfg/Fi.rc      |   10 +++++++++
>  programs/winecfg/Fr.rc      |   10 +++++++++
>  programs/winecfg/Hu.rc      |   10 +++++++++
>  programs/winecfg/It.rc      |   10 +++++++++
>  programs/winecfg/Ja.rc      |   10 +++++++++
>  programs/winecfg/Ko.rc      |   10 +++++++++
>  programs/winecfg/Lt.rc      |   10 +++++++++
>  programs/winecfg/Nl.rc      |   10 +++++++++
>  programs/winecfg/No.rc      |   10 +++++++++
>  programs/winecfg/Pl.rc      |   10 +++++++++
>  programs/winecfg/Pt.rc      |   20 +++++++++++++++++
>  programs/winecfg/Ro.rc      |   10 +++++++++
>  programs/winecfg/Ru.rc      |   10 +++++++++
>  programs/winecfg/Si.rc      |   10 +++++++++
>  programs/winecfg/Sv.rc      |   10 +++++++++
>  programs/winecfg/Tr.rc      |   10 +++++++++
>  programs/winecfg/Zh.rc      |   20 +++++++++++++++++
>  programs/winecfg/driveui.c  |   48 ++++++++++++++++++++++++++++++++++++++++++-
>  programs/winecfg/resource.h |    2 +
>  25 files changed, 299 insertions(+), 1 deletions(-)
>
> diff --git a/programs/winecfg/Bg.rc b/programs/winecfg/Bg.rc
> index fcdf895..8ac2c67 100644
> --- a/programs/winecfg/Bg.rc
> +++ b/programs/winecfg/Bg.rc
> @@ -128,6 +128,16 @@ BEGIN
>     PUSHBUTTON      "Îòìåíè",IDCANCEL,77,74,45,14,WS_GROUP
>  END
>
> +IDD_DRIVECHOOSE DIALOG DISCARDABLE  60, 70, 170, 60
> +STYLE DS_MODALFRAME | WS_CAPTION | WS_SYSMENU
> +CAPTION "Select Drive Letter"
> +FONT 8, "MS Shell Dlg"

Howdy Rein,

I don't believe you're supposed to add English resources to
non-English rc files. The dialog will automatically fall back to
English if not present. It messes up the translation stats..

winecfg: Let the user specify the drive letter of a to be added drive.

[Rein Klazes]

On Sun, 16 Aug 2009 13:18:56 -0500, you wrote:
> Howdy Rein,
>
> I don't believe you're supposed to add English resources to
> non-English rc files. The dialog will automatically fall back to
> English if not present. It messes up the translation stats..

Is that so? I looked through the changelog for winecfg, found a similar
patch that did it this way.

I'll send an updated patch anyway.

Rein.

winecfg: Let the user specify the drive letter of a to be added drive.

[Vitaliy Margolen]

Rein Klazes wrote:
> On Sun, 16 Aug 2009 13:18:56 -0500, you wrote:
> > Howdy Rein,
> >
> > I don't believe you're supposed to add English resources to
> > non-English rc files. The dialog will automatically fall back to
> > English if not present. It messes up the translation stats..
>
> Is that so? I looked through the changelog for winecfg, found a similar
> patch that did it this way.

It works this way only when you are adding a completely new dialog. But if
you are modifying an already existing one, you do need to fix all languages
to stay in sync, if the change is important enough.

Vitaliy.