[PATCH vkd3d 4/7] tests: Clear RTV outside pipeline statistics query.

[Józef Kucia]

From: Józef Kucia

On RADV additional vertices generated by clears are also counted.

The Vulkan spec allows this behavior:

"Rendering operations such as clears, MSAA resolves, attachment
load/store operations, and blits may count towards the results of
queries."

Signed-off-by: Józef Kucia 
---
 tests/d3d12.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/d3d12.c b/tests/d3d12.c
index dd842bc461ae..73f4da96686a 100644
--- a/tests/d3d12.c
+++ b/tests/d3d12.c
@@ -16898,11 +16898,11 @@ static void test_query_pipeline_statistics(void)
     ID3D12GraphicsCommandList_ResolveQueryData(command_list, query_heap, D3D12_QUERY_TYPE_PIPELINE_STATISTICS, 0, 1,
             resource, 0);

+    ID3D12GraphicsCommandList_ClearRenderTargetView(command_list, context.rtv, white, 0, NULL);
+
     /* Second query: draw something simple. */
     ID3D12GraphicsCommandList_BeginQuery(command_list, query_heap, D3D12_QUERY_TYPE_PIPELINE_STATISTICS, 1);

-    ID3D12GraphicsCommandList_ClearRenderTargetView(command_list, context.rtv, white, 0, NULL);
-
     ID3D12GraphicsCommandList_OMSetRenderTargets(command_list, 1, &context.rtv, FALSE, NULL);
     ID3D12GraphicsCommandList_SetGraphicsRootSignature(command_list, context.root_signature);
     ID3D12GraphicsCommandList_SetPipelineState(command_list, context.pipeline_state);

[Henri Verbeet]

Signed-off-by: Henri Verbeet

[Henri Verbeet]

On Mon, 8 Oct 2018 at 17:09, Józef Kucia  wrote:
> On RADV additional vertices generated by clears are also counted.
>
> The Vulkan spec allows this behavior:
>
> "Rendering operations such as clears, MSAA resolves, attachment
> load/store operations, and blits may count towards the results of
> queries."

How about d3d12?

[Józef Kucia]

On Mon, Oct 8, 2018 at 8:28 PM Henri Verbeet  wrote:
> On Mon, 8 Oct 2018 at 17:09, Józef Kucia  wrote:
> > On RADV additional vertices generated by clears are also counted.
> >
> > The Vulkan spec allows this behavior:
> >
> > "Rendering operations such as clears, MSAA resolves, attachment
> > load/store operations, and blits may count towards the results of
> > queries."
>
> How about d3d12?

It's possible that clears don't count towards the results of queries
in d3d12. We don't have extensive tests for this behavior though. It's
probably not a very critical issue, at least for pipeline statistics
queries.