Fwd: [PATCH 1/3] winmm: Fix mciSendString command parsing on 64-bit.

[Octavian Voicu]

Same here.

---------- Forwarded message ----------
From: Octavian Voicu 
Date: Thu, Aug 26, 2010 at 3:12 PM
Subject: Re: [PATCH 1/3] winmm: Fix mciSendString command parsing on 64-bit.
To: [e-mail]

On Thu, Aug 26, 2010 at 2:15 PM, Octavian Voicu
 wrote:
> I just looked in mmddk.h and they have this:
>
> #ifdef _WIN64
> #define MCI_INTEGER64          13
> #endif // _WIN64
>
> Which is really funny, because I wrote that patch without knowing
> anything about that. Gonna take a look at resources inside a 64-bit
> winmm.dll and report back, but it is pretty obvious what I'll find --
> they wouldn't define MCI_INTEGER64 for nothing.

I can confirm it, the 64-bit dll uses MCI_INTEGER64 (0x0000000D),
while the 32-bit one uses MCI_INTEGER. Maybe we should also have
#ifdefs in mmddk.h and winmm_res.rc.

So, do you want to fix your patches and send them, or do you want me
to continue working on this patch set? You should also send the
mciParser test (btw, I tested my patch set with your extra tests and
they all pass).

Octavian