Command for creating git patches - possible discrepancy in Wine doc pages

[Frédéric Delanoy]

Hi,

I'm about to generate my first wine patches and saw 2 pages in the Wine wiki giving two different commands :
- on http://wiki.winehq.org/GitWine , section 3.6. Generating a patchset to submit, it says
   git format-patch --stdout --keep-subject origin
- on http://www.winehq.org/site/sending_patches - Generating a patch for WineHQ with Git, it says
   git format-patch --stdout --keep-subject --attach origin

(note the additional "--attach").

Being a fresh (couple of days) git user, I just wonder : which command should I use?

Frédéric Delanoy

Command for creating git patches - possible discrepancy in Wine doc pages

[Austin English]

2009/6/14 Frédéric Delanoy :
> Hi,
>
> I'm about to generate my first wine patches and saw 2 pages in the Wine wiki giving two different commands :
> - on http://wiki.winehq.org/GitWine , section 3.6. Generating a patchset to submit, it says
>
> git format-patch --stdout --keep-subject origin
> - on http://www.winehq.org/site/sending_patches - Generating a patch for WineHQ with Git, it says
>
> git format-patch --stdout --keep-subject --attach origin
>
> (note the additional "--attach").
>
> Being a fresh (couple of days) git user, I just wonder : which command should I use?

If you're using git to send your patches for you automatically, use
--attach so the patch is attached to your e-mail.

Though if you're just doing a couple small/simple patches, it's easy
enough to just use:
$ git diff > ~/patch.txt
and attach that to your e-mail client.