Re: notepad pagesetup fix

[Dmitry Timoshkov]

"Vijay Kiran Kamuju"  wrote:
> Changelog
>
> Notepad pagesetup fix
> This fixes BUG#2600
> -DEFPUSHBUTTON "OK",         0x151,                   180,  3, 40, 15, WS_TABSTOP
> -PUSHBUTTON    "Cancel",     0x152,               180, 21, 40, 15, WS_TABSTOP
> -PUSHBUTTON    "&Help",       0x153,                180, 39, 40, 15, WS_TABSTOP
> +DEFPUSHBUTTON "OK",         IDOK,                   180,  3, 40, 15, WS_TABSTOP
> +PUSHBUTTON    "Cancel",     IDCANCEL,               180, 21, 40, 15, WS_TABSTOP
> +PUSHBUTTON    "&Help",      IDHELP,                 180, 39, 40, 15, WS_TABSTOP

If you went to the trouble of fixing the bug for English, would you
mind fixing it for other language .rc file as well? Otherwise there is
no point in fixing it only for En.rc.

Alexandre, please do not commit this patch in its current state.

notepad pagesetup fix

[Jonathan Ernst]

Le mardi 04 octobre 2005 à 19:17 +0900, Dmitry Timoshkov a écrit :
> "Vijay Kiran Kamuju"  wrote:
> > Changelog
> >
> > Notepad pagesetup fix
> > This fixes BUG#2600
> > -DEFPUSHBUTTON "OK",         0x151,                   180,  3, 40, 15, WS_TABSTOP
> > -PUSHBUTTON    "Cancel",     0x152,               180, 21, 40, 15, WS_TABSTOP
> > -PUSHBUTTON    "&Help",       0x153,                180, 39, 40, 15, WS_TABSTOP
> > +DEFPUSHBUTTON "OK",         IDOK,                   180,  3, 40, 15, WS_TABSTOP
> > +PUSHBUTTON    "Cancel",     IDCANCEL,               180, 21, 40, 15, WS_TABSTOP
> > +PUSHBUTTON    "&Help",      IDHELP,                 180, 39, 40, 15, WS_TABSTOP
>
> If you went to the trouble of fixing the bug for English, would you
> mind fixing it for other language .rc file as well? Otherwise there is
> no point in fixing it only for En.rc.
>
> Alexandre, please do not commit this patch in its current state.

Here is the updated patch that fixes it for each language.