re: Add d3drmdef.h header

[Dan Kegel]

vijay wrote:
> [complete d3drmdef.h]

It seems premature to check that in without any code that uses it.

Also, did you really write all that yourself?
- Dan

Add d3drmdef.h header

[Vijay Kiran Kamuju]

Hi,

I thought for completeness, we provide the entire header.
I did write all that with the help DirectX SDK. (Phew It took me 3 hrs
to type it)

Thanks,
VJ

On 3/12/07, Dan Kegel  wrote:
> vijay wrote:
> > [complete d3drmdef.h]
>
> It seems premature to check that in without any code that uses it.
>
> Also, did you really write all that yourself?
> - Dan

Add d3drmdef.h header

[Dmitry Timoshkov]

"Vijay Kiran Kamuju"  wrote:
> I thought for completeness, we provide the entire header.
> I did write all that with the help DirectX SDK. (Phew It took me 3 hrs
> to type it)

If it ends up as an almost exact copy of a microsoft header it's not worth an effort.
> +#ifndef __D3DRMDEFS_H__
> +#define __D3DRMDEFS_H__

That's exactly how microsoft does it, this is not how we do it in Wine.
> +#ifndef D3DRMAPI
> +#define D3DRMAPI WINAPI 
> +#endif

Same here.
> +#define D3DRMOPTIONS_LEFTHANDED  0x00000001L

Same here, and in a lot of other places.

You lost 3 hours typing it, we lost time reviewing it. This not the 1st time.

Add d3drmdef.h header

[Vijay Kiran Kamuju]

Hi

On 3/12/07, Dmitry Timoshkov  wrote:
> "Vijay Kiran Kamuju"  wrote:
> > I thought for completeness, we provide the entire header.
> > I did write all that with the help DirectX SDK. (Phew It took me 3 hrs
> > to type it)
>
> If it ends up as an almost exact copy of a microsoft header it's not worth an effort.
> > +#ifndef __D3DRMDEFS_H__
> > +#define __D3DRMDEFS_H__

I saw d3dtypes.h and other d3d header files, its defined like this
only, no wine prefix has been added.
> That's exactly how microsoft does it, this is not how we do it in Wine.
> > +#ifndef D3DRMAPI
> > +#define D3DRMAPI WINAPI
> > +#endif

In some header files its defined like this.
I will remove all of the below and submit a minimalistic header file.
That will support the d3drmvector functions.
Consider this patch as for the record.
> Same here.
> > +#define D3DRMOPTIONS_LEFTHANDED  0x00000001L
>
> Same here, and in a lot of other places.
>
> You lost 3 hours typing it, we lost time reviewing it. This not the 1st time.

I have problems porting header files from native SDK's
> --
> Dmitry.

Thanks,
VJ

Add d3drmdef.h header

[Dmitry Timoshkov]

"Vijay Kiran Kamuju"  wrote:
> > > +#ifndef __D3DRMDEFS_H__
> > > +#define __D3DRMDEFS_H__
>
> I saw d3dtypes.h and other d3d header files, its defined like this
> only, no wine prefix has been added.

No, it's not defined like this.
> > That's exactly how microsoft does it, this is not how we do it in Wine.
> > > +#ifndef D3DRMAPI
> > > +#define D3DRMAPI WINAPI
> > > +#endif
>
> In some header files its defined like this.
> I will remove all of the below and submit a minimalistic header file.

I'd suggest to leave this job to somebody knowledgeable, and who really needs
this file.
> > You lost 3 hours typing it, we lost time reviewing it. This not the 1st time.
>
> I have problems porting header files from native SDK's

Then don't do that.

Add d3drmdef.h header

[Vijay Kiran Kamuju]

Hi,

I have sent the fix for the problematic file, which I used a base.
There a bug in bugzilla 7386
(http://bugs.winehq.org/show_bug.cgi?id=7386) , which needs
implementation of D3DRM's vector functions.
These are pure math functions. I am improving the fix given in
bugzilla 7442 (http://bugs.winehq.org/show_bug.cgi?id=7442)
I have to write test cases, I dont have DirectX SDK and my net connection sucks.

Thanks,
VJ

On 3/13/07, Dmitry Timoshkov  wrote:
> "Vijay Kiran Kamuju"  wrote:
> > > > +#ifndef __D3DRMDEFS_H__
> > > > +#define __D3DRMDEFS_H__
> >
> > I saw d3dtypes.h and other d3d header files, its defined like this
> > only, no wine prefix has been added.
>
> No, it's not defined like this.
> > > That's exactly how microsoft does it, this is not how we do it in Wine.
> > > > +#ifndef D3DRMAPI
> > > > +#define D3DRMAPI WINAPI
> > > > +#endif
> >
> > In some header files its defined like this.
> > I will remove all of the below and submit a minimalistic header file.
>
> I'd suggest to leave this job to somebody knowledgeable, and who really needs
> this file.
> > > You lost 3 hours typing it, we lost time reviewing it. This not the 1st time.
> >
> > I have problems porting header files from native SDK's
>
> Then don't do that.
>
> --
> Dmitry.