Re:

[GOUJON Alexandre]

On 07/18/2010 04:17 PM, Tom Wickline wrote:
> You forgot to attach the patches :) and a subjust is nice as well.
>
> Tom
>
> On Sun, Jul 18, 2010 at 6:16 PM, Alexandre Goujon 
> <[e-mail] > wrote:
> Here is another big path; should fix bug #18071.
> These tests crash on NT4 but I don't really know how to handle this.
> I found #ifdef CRASHES_ON_NT40 in advapi32/tests/crypt.c so I'm
> using it.
>
> I don't know if I have to do git reset before submitting another
> patch so let me know.

Yeah you're right.
I did "git send-email --compse out" which let me type this comment 
(http://source.winehq.org/patches/data/63618) explaining data/63619.

Then, I git-apply'ed another patch and I did again the same command.
So the http://source.winehq.org/patches/data/63621 comment is for 
data/6362[2-3]
As you can see, data/63623 is the same patch as data/63619 : I did't do 
git-reset but I rm'ed out/

What I want is to add a comment to some patch before the

---
  dlls/advapi32/security.c       |   69 ++++++++++++++++++++++++++++-----------
  dlls/advapi32/tests/security.c |   27 +++++++++++++++

2 files changed, 76 insertions(+), 20 deletions(-)

for instance.

Any idea how to do that ?

[Octavian Voicu]

On Sun, Jul 18, 2010 at 6:43 PM, GOUJON Alexandre  wrote:
> What I want is to add a comment to some patch before the
> ...
> for instance.
>
> Any idea how to do that ?

Just do `git format-patch' with proper parameters and this will result
in a series of files, one for each patch in the series.

Then edit each file and add the comments you want just before the
"---" line. Make sure you leave at least one blank line after the
headers.

Then you do `git imap-send *.patch' or something like that. There
might be an easier way though, but doing it like this lets you review
exactly what you are sending before you send it, so I find it pretty
convenient.

Octavian