Am Samstag, den 12.07.2008, 18:46 +0300 schrieb Ismael Barros:
I'm sorry, that patch lacked a header file, this is the fixed patch.
I would put the dplaysp.h file into include, not dlls/dpwsockx. It contains definitions for all DirectPlay service providers, so it might be useful if a modem provider or a direct serial connection provider will be implemented. Is there a reason not to do so?
Regards, Michael Karcher
Nop, actually I also thought the best solution would be to move that file to include, because in fact it's just copied from dlls/dplayx, but AFAIK wine doesn't want to put in include files that are not originally present in Windows.
However, if it's okay I'll move it, much better. I will also have to implement a stub modem provider, so I would have to copy that dplaysp.h again to dlls/dpmodemx, and any change in those definitions would have to be done three times...
On 7/12/08, Michael Karcher wine@mkarcher.dialup.fu-berlin.de wrote:
Am Samstag, den 12.07.2008, 18:46 +0300 schrieb Ismael Barros:
I'm sorry, that patch lacked a header file, this is the fixed patch.
I would put the dplaysp.h file into include, not dlls/dpwsockx. It contains definitions for all DirectPlay service providers, so it might be useful if a modem provider or a direct serial connection provider will be implemented. Is there a reason not to do so?
Regards, Michael Karcher
On Sat, Jul 12, 2008 at 12:25 PM, Ismael Barros razielmine@gmail.com wrote:
Nop, actually I also thought the best solution would be to move that file to include, because in fact it's just copied from dlls/dplayx, but AFAIK wine doesn't want to put in include files that are not originally present in Windows.
However, if it's okay I'll move it, much better. I will also have to implement a stub modem provider, so I would have to copy that dplaysp.h again to dlls/dpmodemx, and any change in those definitions would have to be done three times...
If it's not in the SDK, it can't go into include. Also, please bottom-post on this mailing list.
On 7/12/08, James Hawkins truiken@gmail.com wrote:
On Sat, Jul 12, 2008 at 12:25 PM, Ismael Barros razielmine@gmail.com wrote:
Nop, actually I also thought the best solution would be to move that file to include, because in fact it's just copied from dlls/dplayx, but AFAIK wine doesn't want to put in include files that are not originally present in Windows.
However, if it's okay I'll move it, much better. I will also have to implement a stub modem provider, so I would have to copy that dplaysp.h again to dlls/dpmodemx, and any change in those definitions would have to be done three times...
If it's not in the SDK, it can't go into include. Also, please bottom-post on this mailing list.
As the Peter Hunnisett (author of dplaysp.h) told me, you have to ask Microsoft for the documentation and interface to create a new service provider, as this information was not made public because they never thought it were to become useful for anyone. I suppose this file was extracted from that documentation, but I can't confirm it yet.
Am Samstag, den 12.07.2008, 12:40 -0500 schrieb James Hawkins:
On Sat, Jul 12, 2008 at 12:25 PM, Ismael Barros razielmine@gmail.com wrote:
but AFAIK wine doesn't want to put in include files that are not originally present in Windows.
If it's not in the SDK, it can't go into include. Also, please bottom-post on this mailing list.
OK, you got a point. So, what about an uninstalled file in include/wine? Not all files from there get installed.
Regards, Michael Karcher
On Sat, Jul 12, 2008 at 2:21 PM, Michael Karcher wine@mkarcher.dialup.fu-berlin.de wrote:
Am Samstag, den 12.07.2008, 12:40 -0500 schrieb James Hawkins:
On Sat, Jul 12, 2008 at 12:25 PM, Ismael Barros razielmine@gmail.com wrote:
but AFAIK wine doesn't want to put in include files that are not originally present in Windows.
If it's not in the SDK, it can't go into include. Also, please bottom-post on this mailing list.
OK, you got a point. So, what about an uninstalled file in include/wine? Not all files from there get installed.
Maybe. You'd have to ask Julliard.
Hello Alexandre,
this thread is about an include file specifying the interface between dplayx.dll and the DirectPlay service providers. As it is not in the Windows Platform SDK, James Hawkins explained that it may not go into include. This file is shared between dplayx and the service providers, currently two copies exist (if the patch that started the discussion gets applied), and if a modem provider gets written, three copies exist. What do you think would be the appropriate location of that file?
Am Samstag, den 12.07.2008, 14:31 -0500 schrieb James Hawkins:
If it's not in the SDK, it can't go into include.
OK, you got a point. So, what about an uninstalled file in include/wine? Not all files from there get installed.
Maybe. You'd have to ask Julliard.
Regards, Michael Karcher
Michael Karcher wine@mkarcher.dialup.fu-berlin.de writes:
Hello Alexandre,
this thread is about an include file specifying the interface between dplayx.dll and the DirectPlay service providers. As it is not in the Windows Platform SDK, James Hawkins explained that it may not go into include. This file is shared between dplayx and the service providers, currently two copies exist (if the patch that started the discussion gets applied), and if a modem provider gets written, three copies exist. What do you think would be the appropriate location of that file?
If it's part of some DirectPlay SDK then it can go in include, otherwise it will probably have to go in include/wine.
On 7/13/08, Alexandre Julliard julliard@winehq.org wrote:
Michael Karcher wine@mkarcher.dialup.fu-berlin.de writes:
Hello Alexandre,
this thread is about an include file specifying the interface between dplayx.dll and the DirectPlay service providers. As it is not in the Windows Platform SDK, James Hawkins explained that it may not go into include. This file is shared between dplayx and the service providers, currently two copies exist (if the patch that started the discussion gets applied), and if a modem provider gets written, three copies exist. What do you think would be the appropriate location of that file?
If it's part of some DirectPlay SDK then it can go in include, otherwise it will probably have to go in include/wine.
It's not part of any official DirectPlay SDK, but I suppose it's part of the documentation Microsoft provides if you ask them for the interfaces needed to develop a new service provider. However I can't confirm this yet (they agreed to provide me the documentation, but I've got no news from them since then), so include/wine is probably the place then.
What would be the exact path? include/wine/dplaysp.h? include/wine/dplay/dplaysp.h?
Cheers Ismael
-
Alexandre Julliard -
Ismael Barros -
James Hawkins -
Michael Karcher