On November 13, 2002 02:38 pm, Alexandre Julliard wrote:
Reduce the maximum length of debug strings to 80 characters.
Why do that? My console has >140 columns, 80 is rather small.
"Dimitrie O. Paun" dpaun@rogers.com writes:
Why do that? My console has >140 columns, 80 is rather small.
It's to avoid buffer overflows. With escapes, 80 chars can potentially grow to 400 chars.
On November 13, 2002 03:27 pm, Alexandre Julliard wrote:
It's to avoid buffer overflows. With escapes, 80 chars can potentially grow to 400 chars.
Yes, I thought it would be related to buffer sizes, but it does not look like the right fix. We should check, and not exceed, the size of the buffer, not limit the input to the worse case safe minimum. I'll look at an alternative fix.
"Dimitrie O. Paun" dpaun@rogers.com writes:
Yes, I thought it would be related to buffer sizes, but it does not look like the right fix. We should check, and not exceed, the size of the buffer, not limit the input to the worse case safe minimum. I'll look at an alternative fix.
The problem is not the string buffer itself, it's the output buffer. You can't really know what limit to use for that because you don't know what else the caller is printing at the same time. Anyway 80 chars should be more than enough to figure out what the string is about.
On November 13, 2002 06:29 pm, Alexandre Julliard wrote:
The problem is not the string buffer itself, it's the output buffer.
Right, I confused the two, when I looked over it quickly. Yeah, 80 chars should be more than enough.
-
Alexandre Julliard -
Dimitrie O. Paun