Re: [02/10] wintrust: Convert crypt tests to Unicode.

[Alexandre Julliard]

Hans Leidekker  writes:
> diff --git a/dlls/wintrust/tests/crypt.c b/dlls/wintrust/tests/crypt.c
> index 6811fd4..41cb39a 100644
> --- a/dlls/wintrust/tests/crypt.c
> +++ b/dlls/wintrust/tests/crypt.c
> @@ -27,8 +27,8 @@
>
> #include "wine/test.h"
>
> -static char selfname[MAX_PATH];
> -static CHAR CURR_DIR[MAX_PATH];
> +static WCHAR selfname[MAX_PATH];
> +static WCHAR current_dir[MAX_PATH];

Is that really useful?  It seems to me it will break the tests on Win9x
for no good reason.

[02/10] wintrust: Convert crypt tests to Unicode.

[Hans Leidekker]

On Monday 22 December 2008 14:54:28 Alexandre Julliard wrote:
> > -static char selfname[MAX_PATH];
> > -static CHAR CURR_DIR[MAX_PATH];
> > +static WCHAR selfname[MAX_PATH];
> > +static WCHAR current_dir[MAX_PATH];
>
> Is that really useful?  It seems to me it will break the tests on Win9x
> for no good reason.

Well, wintrust is a Unicode only API and we already skip the tests if
wintrust is not fully supported.

-Hans

[02/10] wintrust: Convert crypt tests to Unicode.

[Alexandre Julliard]

Hans Leidekker  writes:
> On Monday 22 December 2008 14:54:28 Alexandre Julliard wrote:
> > > -static char selfname[MAX_PATH];
> > > -static CHAR CURR_DIR[MAX_PATH];
> > > +static WCHAR selfname[MAX_PATH];
> > > +static WCHAR current_dir[MAX_PATH];
> >
> > Is that really useful?  It seems to me it will break the tests on Win9x
> > for no good reason.
>
> Well, wintrust is a Unicode only API and we already skip the tests if
> wintrust is not fully supported.

Wintrust being Unicode doesn't mean the rest of the system has to
be. The tests currently run (with some errors) on WinME.