Re: wine/dlls/x11drv x11drv_main.c

[liu spider]

It crashed every time when I closed an app, not just
"sometimes" :(

And I think maybe exchange the calling order of
XCloseIM and XCloseDisplay is a better method than
just comments out XCloseIM ( I think this will lead to
some other problems).

--- Alexandre Julliard 
wrote:
> ChangeSet ID:	7168
> CVSROOT:	/opt/cvs-commit
> Module name:	wine
> Changes by:	[e-mail]	2003/01/29
> 19:08:53
>
> Modified files:
>    dlls/x11drv    : x11drv_main.c
>
> Log message:
>    XCloseIM sometimes crashes in Xlib, don't call it.
>
> Patch: http://cvs.winehq.com/patch.py?id=7168
>
> Old revision  New revision  Changes     Path
>  1.67          1.68          +1 -1      
> wine/dlls/x11drv/x11drv_main.c

__________________________________________________
Do you Yahoo!?
Yahoo! Mail Plus - Powerful. Affordable. Sign up now.
http://mailplus.yahoo.com

wine/dlls/x11drv x11drv_main.c

[Alexandre Julliard]

liu spider  writes:
> And I think maybe exchange the calling order of
> XCloseIM and XCloseDisplay is a better method than
> just comments out XCloseIM ( I think this will lead to
> some other problems).

Exchanging them makes it crash on my machine, so I think we have to
avoid the close, unless someone wants to chase the bug. I suspect the
problem is in Xlib though, we're probably the only app trying to
properly close an IM...

wine/dlls/x11drv x11drv_main.c

[liu spider]

hi Alexandre
Could you tell me the progress of the work on adding
XIM support to WINE? 
I just found that I could not even trigger my XIM
using the lates CVS.
Thanks
> Exchanging them makes it crash on my machine, so I
> think we have to
> avoid the close, unless someone wants to chase the
> bug. I suspect the
> problem is in Xlib though, we're probably the only
> app trying to
> properly close an IM...
>
> -- 
> Alexandre Julliard
> [e-mail]

__________________________________________________
Do you Yahoo!?
Yahoo! Tax Center - forms, calculators, tips, more
http://taxes.yahoo.com/

wine/dlls/x11drv x11drv_main.c

[Alexandre Julliard]

liu spider  writes:
> hi Alexandre
> Could you tell me the progress of the work on adding
> XIM support to WINE?

Not much progress lately I'm afraid, I've had other priorities.
> I just found that I could not even trigger my XIM
> using the lates CVS.

Is that a new bug or was it always this way?

XIM support patch 3rd

[liu spider]

--- Alexandre Julliard  wrote:
> Is that a new bug or was it always this way?

Oh, sorry, I just found it's the XIM's fault , not
related to wine.
> Not much progress lately I'm afraid, I've had other
> priorities.

I use the "old method" to implement XIM support using
the newly added functions in wine. It works in some
cases, but don't in other. 
And should I submit the patch or just wait for you to
work on it later?

__________________________________________________
Do you Yahoo!?
Yahoo! Tax Center - forms, calculators, tips, more
http://taxes.yahoo.com/

XIM support patch 3rd

[Alexandre Julliard]

liu spider  writes:
> I use the "old method" to implement XIM support using
> the newly added functions in wine. It works in some
> cases, but don't in other. 
> And should I submit the patch or just wait for you to
> work on it later?

It never hurts to submit a patch. Even if I don't apply it as is, it
can still be a useful reference for further work.