Re: [PATCH] kernel32: Load library search in system32 directory.

[Alexandre Julliard]

Carlos Palminha  writes:
> Use %windows%\system32 directory to search for the DLL.
> Standard search path is not used.
> Signed-off-by: Carlos Palminha
>
> dlls/kernel32/module.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)

%windows% cannot possibly work, environment variables are not expanded,
and even if they were, there's no such variable. How did you test this?

Also it's possible to specify multiple flags, this needs to be
integrated properly in the code that builds the search path.

[PATCH] kernel32: Load library search in system32 directory.

[Carlos Palminha]

Hi Alexandre,

I tested with iTunes installation that was crashing when calling load_libraryin my system. After the patch it was ok. Probably not enough indicator that was working properly in all systems.

I will send a second version calling GetWindowsDirectory instead of using %windows%.

Regarding the other cases, when using the flag LOAD_LIBRARY_SEARCH_SYSTEM32, directories in the standard search path are not searched and the value cannot be combined with LOAD_WITH_ALTERED_SEARCH_PATH. The search path is reduced to windows\system32, right? Or probably i need to append %windows&\system32 to the existing path...

Regards,
C.Palminha

On 31-07-2017 17:25, Alexandre Julliard wrote:
> Carlos Palminha  writes:
> > Use %windows%\system32 directory to search for the DLL.
> > Standard search path is not used.
> > Signed-off-by: Carlos Palminha
> >
> > dlls/kernel32/module.c | 10 ++++++++--
> >  1 file changed, 8 insertions(+), 2 deletions(-)
>
> %windows% cannot possibly work, environment variables are not expanded,
> and even if they were, there's no such variable. How did you test this?
>
> Also it's possible to specify multiple flags, this needs to be
> integrated properly in the code that builds the search path.

[PATCH] kernel32: Load library search in system32 directory.

[Alexandre Julliard]

Carlos Palminha  writes:
> Hi Alexandre,
>
> I tested with iTunes installation that was crashing when calling load_libraryin my system. After the patch it was ok. Probably not enough indicator that was working properly in all systems.
>
> I will send a second version calling GetWindowsDirectory instead of using %windows%.
>
> Regarding the other cases, when using the flag
> LOAD_LIBRARY_SEARCH_SYSTEM32, directories in the standard search path
> are not searched and the value cannot be combined with
> LOAD_WITH_ALTERED_SEARCH_PATH. The search path is reduced to
> windows\system32, right? Or probably i need to append
> %windows&\system32 to the existing path...

If you only specify SEARCH_SYSTEM32 the path is reduced to that, but you
could also have other flags like SEARCH_APPLICATION_DIR,
SEARCH_DLL_LOAD_DIR, etc.  You can't handle just one flag and ignore the
others.

[PATCH] kernel32: Load library search in system32 directory.

[Carlos Palminha]

On 31-07-2017 17:54, Alexandre Julliard wrote:
> Carlos Palminha  writes:
> > Hi Alexandre,
> >
> > I tested with iTunes installation that was crashing when calling load_libraryin my system. After the patch it was ok. Probably not enough indicator that was working properly in all systems.
> >
> > I will send a second version calling GetWindowsDirectory instead of using %windows%.
> >
> > Regarding the other cases, when using the flag
> > LOAD_LIBRARY_SEARCH_SYSTEM32, directories in the standard search path
> > are not searched and the value cannot be combined with
> > LOAD_WITH_ALTERED_SEARCH_PATH. The search path is reduced to
> > windows\system32, right? Or probably i need to append
> > %windows&\system32 to the existing path...
>
> If you only specify SEARCH_SYSTEM32 the path is reduced to that, but you
> could also have other flags like SEARCH_APPLICATION_DIR,
> SEARCH_DLL_LOAD_DIR, etc.  You can't handle just one flag and ignore the
> others.

All the other cases SEARCH_APPLICATION_DIR, SEARCH_DEFAULT_DIRS, SEARCH_DLL_LOAD_DIR and SEARCH_USER_DIRS are not yet supported (unsopported flags).
So at this moment LOAD_LIBRARY_SEARCH_* are reduced to ALTERED_SEARCH_PATH or SEARCH_SYSTEM32.

Regards,
C.Palminha