Should SetManagedHandler really fail if the given object doesn't support ICorDebugManagedCallback2 ?
You've got a stray whitespace change in RuntimeHost_Destroy.
Otherwise, this looks good to me.
On Mon, Oct 10, 2011 at 5:12 AM, Alistair Leslie-Hughes leslie_alistair@hotmail.com wrote:
Hi,
Only Release the interfaces after we have a valid callback. Allow multiple Interfaces per runtime.
Changelog: mscoree: Implement ICorDebug SetManagedHandler
Best Regards Alistair Leslie-Hughes
On 11/10/2011 2:07 AM, Vincent Povirk wrote:
Should SetManagedHandler really fail if the given object doesn't support ICorDebugManagedCallback2 ?
Yes, this is a requirement for debugging .NET 2 applications.
Best Regards Alistair Leslie-Hughes
Can we have a WARN message in case of .NET 1 applications?
On Mon, Oct 10, 2011 at 2:36 PM, Alistair Leslie-Hughes leslie_alistair@hotmail.com wrote:
On 11/10/2011 2:07 AM, Vincent Povirk wrote:
Should SetManagedHandler really fail if the given object doesn't support ICorDebugManagedCallback2 ?
Yes, this is a requirement for debugging .NET 2 applications.
Best Regards Alistair Leslie-Hughes
-
Alistair Leslie-Hughes -
Vincent Povirk