Re: [PATCH] include/wincodec.idl: Stop redefinition of ID2D1Image

[Sebastian Lackner]

On 14.06.2017 13:54, Alistair Leslie-Hughes wrote:
> Fixes: https://bugs.winehq.org/show_bug.cgi?id=43175
> Signed-off-by: Alistair Leslie-Hughes
>
> include/wincodec.idl | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/include/wincodec.idl b/include/wincodec.idl
> index 1ea6e0e203..bdc2031ac3 100644
> --- a/include/wincodec.idl
> +++ b/include/wincodec.idl
> @@ -224,7 +224,9 @@ typedef DWORD *D2D1_PIXEL_FORMAT;
>  cpp_quote ("#endif")
>
> cpp_quote ("typedef interface ID2D1Device ID2D1Device;")
> +cpp_quote ("#ifndef __ID2D1Image_FWD_DEFINED__")
>  cpp_quote ("typedef interface ID2D1Image ID2D1Image;")
> +cpp_quote ("#endif")
>
> typedef struct WICRect {
>      INT X;

And what if the include files are used in the opposite order?
You don't define __ID2D1Image_FWD_DEFINED__, so the bug will reappear.

Best regards,
Sebastian

[PATCH] include/wincodec.idl: Stop redefinition of ID2D1Image

[Henri Verbeet]

What problem are you trying to avoid in the first place by not simply
having a forward declaration (i.e., "interface ID2D1Image;")?