On 2/11/2010 19:51, Justin Chevrier wrote:
dlls/msctf/langbarmgr.c | 193 +++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 193 insertions(+), 0 deletions(-) create mode 100644 dlls/msctf/langbarmgr.c
- This = HeapAlloc(GetProcessHeap(),HEAP_ZERO_MEMORY,sizeof(LangBarMgr));
You don't need HEAP_ZERO_MEMORY here, cause you will set all fields anyway.
Also it looks like you specially split to several patches to have only one file per patch, that's not needed.
Thanks for the feed back!
I should have went with my gut on these and sent them through together. They were really meant to all be applied in one go.
Justin
On Thu, Feb 11, 2010 at 12:22 PM, Nikolay Sivov bunglehead@gmail.com wrote:
On 2/11/2010 19:51, Justin Chevrier wrote:
dlls/msctf/langbarmgr.c | 193 +++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 193 insertions(+), 0 deletions(-) create mode 100644 dlls/msctf/langbarmgr.c
- This =
HeapAlloc(GetProcessHeap(),HEAP_ZERO_MEMORY,sizeof(LangBarMgr));
You don't need HEAP_ZERO_MEMORY here, cause you will set all fields anyway.
Also it looks like you specially split to several patches to have only one file per patch, that's not needed.
Thanks for the feed back!
I should have went with my gut on these and sent them through together. They were really meant to all be applied in one go.
Justin
On Thu, Feb 11, 2010 at 12:22 PM, Nikolay Sivov bunglehead@gmail.com wrote:
On 2/11/2010 19:51, Justin Chevrier wrote:
dlls/msctf/langbarmgr.c | 193 +++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 193 insertions(+), 0 deletions(-) create mode 100644 dlls/msctf/langbarmgr.c
- This =
HeapAlloc(GetProcessHeap(),HEAP_ZERO_MEMORY,sizeof(LangBarMgr));
You don't need HEAP_ZERO_MEMORY here, cause you will set all fields anyway.
Also it looks like you specially split to several patches to have only one file per patch, that's not needed.
-
Justin Chevrier -
Nikolay Sivov