This patch should fix the regresion introduced by baea371c3d4153bc4a718c07f46971d4d39aa9f3.
Signed-off-by: Dmitry Timoshkov dmitry@baikal.ru --- dlls/msi/package.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dlls/msi/package.c b/dlls/msi/package.c index 3374964078..8e9ae6dd90 100644 --- a/dlls/msi/package.c +++ b/dlls/msi/package.c @@ -1742,7 +1742,7 @@ MSIHANDLE WINAPI MsiGetActiveDatabase(MSIHANDLE hInstall) { __TRY { - handle = remote_GetActiveDatabase(hInstall); + handle = remote_GetActiveDatabase(remote); handle = alloc_msi_remote_handle(handle); } __EXCEPT(rpc_filter)
On 18/09/18 00:59, Dmitry Timoshkov wrote:
This patch should fix the regresion introduced by baea371c3d4153bc4a718c07f46971d4d39aa9f3.
Signed-off-by: Dmitry Timoshkov dmitry@baikal.ru
dlls/msi/package.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dlls/msi/package.c b/dlls/msi/package.c index 3374964078..8e9ae6dd90 100644 --- a/dlls/msi/package.c +++ b/dlls/msi/package.c @@ -1742,7 +1742,7 @@ MSIHANDLE WINAPI MsiGetActiveDatabase(MSIHANDLE hInstall) { __TRY {
handle = remote_GetActiveDatabase(hInstall);
handle = remote_GetActiveDatabase(remote); handle = alloc_msi_remote_handle(handle); } __EXCEPT(rpc_filter)
*facepalm*
Thanks for finding that; I can't *believe* it got past the tests.
Zebediah Figura z.figura12@gmail.com wrote:
*facepalm*
Thanks for finding that;
You're welcome.
I can't *believe* it got past the tests.
Probably it's the proper time to add some :)
On 18/09/18 09:29, Dmitry Timoshkov wrote:
Zebediah Figura z.figura12@gmail.com wrote:
*facepalm*
Thanks for finding that;
You're welcome.
I can't *believe* it got past the tests.
Probably it's the proper time to add some :)
That particular function does have tests; I suspect that the allocated handle numbers just ended up being the same on the local and remote sides...