The attached patch (sorry, crappy mailer) fixes the win.c failure I was seeing. Is it correct?
--Juan
__________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com
"Juan Lang" juan_lang@yahoo.com wrote:
The attached patch (sorry, crappy mailer) fixes the win.c failure I was seeing. Is it correct?
No it's not correct. Does the attached patch fix the failure?
No it's not correct. Does the attached patch fix the failure?
Not sure. I get a similar failure on an earlier line: win.c:2508: Test failed: message 0200 available
This is the repeated failure after rerunning the tests several times to get past earlier intermittent failures.
--Juan
__________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com
"Juan Lang" juan_lang@yahoo.com wrote:
Not sure. I get a similar failure on an earlier line: win.c:2508: Test failed: message 0200 available
This is the repeated failure after rerunning the tests several times to get past earlier intermittent failures.
0x200 is WM_MOUSEMOVE. So it's that you either moving the mouse during the test, or there is some other source of that message. Juan, you need to investigate what is going on if that's the latter.
--- Dmitry Timoshkov dmitry@codeweavers.com wrote:
0x200 is WM_MOUSEMOVE. So it's that you either moving the mouse during the test, or there is some other source of that message. Juan, you need to investigate what is going on if that's the latter.
Yes, I know. My mouse is a builtin touchpad (on my laptop) and I ran the tests without touching it. It was sitting stably on a table, and I repeated it several times with the same failure before I replied.
--Juan
__________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com
--- Dmitry Timoshkov dmitry@codeweavers.com wrote:
0x200 is WM_MOUSEMOVE. So it's that you either moving the mouse during the test, or there is some other source of that message. Juan, you need to investigate what is going on if that's the latter.
This appears to be a Heisenbug. I ran the tests four times this morning (in the same manner, on a table, not touching the mousepad.) I got this failure for the first three runs: ../../../tools/runtest -q -P wine -M user32.dll -T ../../.. -p user32_test.e xe.so win.c && touch win.ok fixme:win:WIN_CreateWindowEx Parent is HWND_MESSAGE win.c:2414: Test failed: message 000f available win.c:2422: Test failed: message 000f available win.c:2430: Test failed: message 000f available make: *** [win.ok] Error 3
On the fourth run it succeeded. I know you know that these are WM_PAINT again. --Juan
__________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com
"Juan Lang" juan_lang@yahoo.com wrote:
win.c:2414: Test failed: message 000f available win.c:2422: Test failed: message 000f available win.c:2430: Test failed: message 000f available make: *** [win.ok] Error 3
On the fourth run it succeeded. I know you know that these are WM_PAINT again.
Does moving flush_events() a bit further like in the attached patch help? If it doesn't, please try to change 100 in flush_events to 200 or even more and see if that helps.
Hi Dmitry,
--- Dmitry Timoshkov dmitry@codeweavers.com wrote:
Does moving flush_events() a bit further like in the attached patch help?
It seems to help a bit, it fails about 50% of the time just by moving it.
If it doesn't, please try to change 100 in flush_events to 200 or even more and see if that helps.
200 works great for me--no failures from the first try, and no failures after repeated attempts. Thanks! --Juan
__________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com
-
Dmitry Timoshkov -
Juan Lang